Skip to content

cmake: fix processing order of <wrapper>_bindings_generator#19000

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
alalek:cmake_fix_order_of_bindings_generators
Dec 3, 2020
Merged

cmake: fix processing order of <wrapper>_bindings_generator#19000
opencv-pushbot merged 1 commit intoopencv:3.4from
alalek:cmake_fix_order_of_bindings_generators

Conversation

@alalek
Copy link
Copy Markdown
Member

@alalek alalek commented Dec 3, 2020 •
edited
Loading

Currently only python_bindings_generator is properly handled.

Other cases (java, obj, +added js) may not work.
In case of #18965 (js) we have this order:

OPENCV_MODULES_BUILD=opencv_core;opencv_imgproc;opencv_js_bindings_generator;opencv_python_tests;opencv_video;opencv_dnn;opencv_features2d;opencv_calib3d;opencv_objdetect;opencv_js

(dnn module is not processed before opencv_js_bindings_generator - this is necessary to fill *_opencv_dnn_HEADERS variable)

force_builders_only=linux
#,Custom,Custom Mac
build_image:Docs=docs-js
build_image:Custom=javascript
buildworker:Custom=linux-4
build_image:Custom Mac=osx_framework
buildworker:Custom Mac=macosx-2

@alalek
cmake: fix processing order of <wrapper>_bindings_generator
b31ce40 
- ensure that wrapped modules are already processed
@alalek
Copy link
Copy Markdown
Member Author

alalek commented Dec 3, 2020

👍

@opencv-pushbot opencv-pushbot merged commit 84a3654 into opencv:3.4 Dec 3, 2020
This was referenced Dec 4, 2020
Merged
Closed
Merged
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mshabunin mshabunin Awaiting requested review from mshabunin

Assignees

@alalek alalek

Labels

bug category: build/install

Projects

None yet

Milestone

3.4.13

Development

Successfully merging this pull request may close these issues.

2 participants

@alalek @opencv-pushbot