Skip to content

[G-API] GStreamingBackend#19009

Merged
alalek merged 14 commits intoopencv:masterfrom
TolyaTalamanov:at/media-frame-copy
Dec 11, 2020
Merged

[G-API] GStreamingBackend#19009
alalek merged 14 commits intoopencv:masterfrom
TolyaTalamanov:at/media-frame-copy

Conversation

@TolyaTalamanov
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov commented Dec 4, 2020 •
edited by smirnov-alexey
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_image:Custom=ubuntu-openvino-2021.1.0:20.04
build_image:Custom Win=openvino-2021.1.0
build_image:Custom Mac=openvino-2021.1.0

test_modules:Custom=gapi
test_modules:Custom Win=gapi
test_modules:Custom Mac=gapi

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

TolyaTalamanov
TolyaTalamanov commented Dec 4, 2020
View reviewed changes
@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Dec 4, 2020

@smirnov-alexey

TolyaTalamanov
TolyaTalamanov commented Dec 5, 2020
View reviewed changes
TolyaTalamanov
TolyaTalamanov commented Dec 5, 2020
View reviewed changes
dmatveev
dmatveev requested changes Dec 8, 2020
View reviewed changes
@smirnov-alexey
Copy link
Copy Markdown
Contributor

smirnov-alexey commented Dec 9, 2020

There are some missing changes to allow MediaFrame be the output object (compared to this #18987).

@smirnov-alexey smirnov-alexey mentioned this pull request Dec 10, 2020
Merged
6 tasks
@smirnov-alexey
Copy link
Copy Markdown
Contributor

smirnov-alexey commented Dec 10, 2020

@dmatveev can you have a look once again?

@smirnov-alexey
Copy link
Copy Markdown
Contributor

smirnov-alexey commented Dec 10, 2020

The build is OK except for 2 warning:

CMake Warning:
  Manually-specified variables were not used by the project:

    ENABLE_CXX11
    INF_ENGINE_RELEASE
    WITH_INF_ENGINE

and

CMake Warning at /opt/intel/openvino_2021.1.110/deployment_tools/inference_engine/share/ie_parallel.cmake:6 (find_package):
  By not providing "FindTBB.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "TBB", but
  CMake did not find one.

Which are not related to this PR

dmatveev
dmatveev reviewed Dec 11, 2020
View reviewed changes
dmatveev
dmatveev approved these changes Dec 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! Hopefully it will be merged soon.

@smirnov-alexey
Copy link
Copy Markdown
Contributor

smirnov-alexey commented Dec 11, 2020

@alalek do we need to add some extra commands to description to our PRs to build them on Arm/etc next time?

@alalek
Copy link
Copy Markdown
Member

alalek commented Dec 11, 2020

No, ARM builders have low throughput, so it is better do not schedule them by default.

@smirnov-alexey
Copy link
Copy Markdown
Contributor

smirnov-alexey commented Dec 11, 2020

@alalek can we merge this? The build is green. Thanks!

@alalek alalek merged commit 8ed0fc6 into opencv:master Dec 11, 2020
@OrestChura OrestChura mentioned this pull request Dec 11, 2020
Merged
6 tasks
@dmatveev
Copy link
Copy Markdown
Contributor

dmatveev commented Dec 14, 2020

Thanks!

@alalek alalek mentioned this pull request Apr 9, 2021
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@TolyaTalamanov @smirnov-alexey
Merge pull request opencv#19009 from TolyaTalamanov:at/media-frame-copy
14f5eb5 
[G-API] GStreamingBackend

* Snapshot

* Implement StreamingBackend

* Refactoring

* Refactoring 2

* Clean up

* Add missing functionality to support MediaFrame as output

* Partially address review comments

* Fix build

* Implement reshape for gstreamingbackend and add a test on it

* Address more comments

* Add format.hpp to gapi.hpp

* Fix debug build

* Address review comments

Co-authored-by: Smirnov Alexey <alexey.smirnov@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AsyaPronina AsyaPronina AsyaPronina left review comments

@smirnov-alexey smirnov-alexey smirnov-alexey left review comments

@dmatveev dmatveev dmatveev approved these changes

Assignees

@dmatveev dmatveev

Labels

category: g-api / gapi feature

Projects

None yet

Milestone

4.5.1

Development

Successfully merging this pull request may close these issues.

5 participants

@TolyaTalamanov @smirnov-alexey @alalek @dmatveev @AsyaPronina