[G-API] Support GFrame for infer by TolyaTalamanov · Pull Request #19002 · opencv/opencv

TolyaTalamanov · 2020-12-03T13:56:54Z

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
The PR is proposed to proper branch
There is reference to original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_image:Custom=ubuntu-openvino-2021.1.0:20.04
build_image:Custom Win=openvino-2021.1.0
build_image:Custom Mac=openvino-2021.1.0

test_modules:Custom=gapi
test_modules:Custom Win=gapi
test_modules:Custom Mac=gapi

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

dmatveev

👍 approved, thanks!

dmatveev · 2020-12-03T14:09:03Z

modules/gapi/src/backends/ie/giebackend.cpp

+                         std::back_inserter(context.in_shapes),
+                         [](const cv::GArg& arg) {
+                             return arg.get<cv::gimpl::RcDesc>().shape;
+                         });


So do you use it really?

use it to distinguish cv::GMat & cv::GFrame

TolyaTalamanov · 2020-12-03T14:23:55Z

@alalek CI is read: error C2039: 'NV12Blob': is not a member of 'InferenceEngine'
Log: https://pullrequest.opencv.org/buildbot/builders/precommit_custom_windows/builds/1707/steps/compile%20release/logs/stdio

Can it be the problem with OpenVINO version ?

https://github.com/openvinotoolkit/openvino/blob/master/inference-engine/samples/hello_nv12_input_classification/main.cpp#L157

alalek · 2020-12-03T14:41:34Z

Mentioned sample is available since OV 2019 R2.

You are testing using OV LTS release:

openvino-2020.3.0

Need to add proper version check through #if if this is necessary to include some headers.

BTW, You can use different OV versions on Linux/Windows/Mac configurations to perform robust checking (recommended).

TolyaTalamanov · 2020-12-04T13:43:43Z

@alalek Custom jobs failed due known problems (cpu options isn't supported in this OV version)

I think it can be merged

alalek · 2020-12-04T14:02:57Z

Custom jobs failed due known problems (cpu options isn't supported in this OV version)
I think it can be merged

Really? I see this:

Results:
Failed compile release

and missing build images (OV LTS 2020.3.1 is not supported for now). Consider using 2021.1 instead.

Compilation must be fixed before merge.

TolyaTalamanov · 2020-12-04T14:54:41Z

Custom jobs failed due known problems (cpu options isn't supported in this OV version)
I think it can be merged

Really? I see this:

Results:
Failed compile release

and missing build images (OV LTS 2020.3.1 is not supported for now). Consider using 2021.1 instead.

Compilation must be fixed before merge.

2021.1 isn't supported on CI, is it ?

alalek · 2020-12-04T15:31:40Z

2021.1 isn't supported on CI, is it ?

Supported (on Linux in Ubuntu 20.04 container): https://github.com/opencv/opencv/wiki/CI-configuration

mpashchenkov · 2020-12-07T16:33:52Z

modules/gapi/src/backends/ie/giebackend.cpp

+                util::throw_error(std::runtime_error("Unsupported input meta for IE backend"));
+        }
+
+        if (util::holds_alternative<cv::GMatDesc>(mm_0)) {


Isn't this checked in switch? For what case is it, if not.

smirnov-alexey · 2020-12-08T12:08:18Z

Was able to successfully built with both 2020.03 and 2021.01 on my Ubuntu 18.04

smirnov-alexey · 2020-12-08T13:40:18Z

@alalek can you have a look at this https://pullrequest.opencv.org/buildbot/builders/precommit_custom_linux/builds/5124?

alalek · 2020-12-08T15:50:17Z

openvino-2021.1

Use this Wiki page for proper names of available build images: https://github.com/opencv/opencv/wiki/CI-configuration

Should be *openvino-2021.1.0*

smirnov-alexey · 2020-12-08T15:59:52Z

openvino-2021.1

Use this Wiki page for proper names of available build images: https://github.com/opencv/opencv/wiki/CI-configuration

Should be *openvino-2021.1.0*

Missed that, thanks!

smirnov-alexey · 2020-12-08T21:11:36Z

@alalek can we merge this if the build will be green? There was a warning on Mac which hopefully will be fixed and other warnings are:

CMake Warning at /opt/intel/openvino_2021.1.110/deployment_tools/inference_engine/share/ie_parallel.cmake:6 (find_package):
  By not providing "FindTBB.cmake" in CMAKE_MODULE_PATH this project has

and

CMake Warning:
  Manually-specified variables were not used by the project:

    ENABLE_CXX11
    INF_ENGINE_RELEASE
    WITH_INF_ENGINE

alalek · 2020-12-09T02:41:35Z

Yes, even with warnings on "optional" configuration (in scope of OpenCV, not G-API) if these warnings are not related to this PR (the same issues are with other G-API PRs on the same configurations).

dmatveev · 2020-12-09T09:01:33Z

Let's merge this - we need this feature for the next internal update

smirnov-alexey · 2020-12-09T09:12:55Z

@alalek the build is green except for 2 warnings I've mentioned above (which have nothing to do with this PR). Can we merge this?

smirnov-alexey · 2020-12-09T14:26:27Z

@alalek Thanks!

dmatveev · 2020-12-09T17:03:07Z

Fantastic!

[G-API] Support GFrame for infer * GInfer(GFrame), currently broken * Fixed (API only) * Support GFrame in GIEBackend * Fix comments to review * Fix comments to review * Fix doxygen * Fix building with different IE versions * Fix warning on MacOS Co-authored-by: Dmitry Matveev <dmitry.matveev@intel.com> Co-authored-by: Smirnov Alexey <alexey.smirnov@intel.com>

dmatveev and others added 5 commits November 23, 2020 12:17

GInfer(GFrame), currently broken

f180ad7

Fixed (API only)

b44e541

Support GFrame in GIEBackend

90d07c5

Fix comments to review

90d5116

Fix comments to review

cf17b6a

TolyaTalamanov added the category: g-api / gapi label Dec 3, 2020

TolyaTalamanov requested review from dmatveev and smirnov-alexey December 3, 2020 13:56

dmatveev approved these changes Dec 3, 2020

View reviewed changes

Fix doxygen

3940579

TolyaTalamanov force-pushed the at/infer_gframe branch from 1e2515e to 3940579 Compare December 4, 2020 10:34

mpashchenkov reviewed Dec 7, 2020

View reviewed changes

smirnov-alexey approved these changes Dec 8, 2020

View reviewed changes

Fix building with different IE versions

f83b37a

smirnov-alexey force-pushed the at/infer_gframe branch from f1579d6 to f83b37a Compare December 8, 2020 15:59

Fix warning on MacOS

c025a38

alalek assigned dmatveev Dec 9, 2020

alalek merged commit a55150b into opencv:master Dec 9, 2020

alalek mentioned this pull request Apr 9, 2021

(5.x) Merge 4.x #19885

Merged

Uh oh!

Conversation

TolyaTalamanov commented Dec 3, 2020 • edited by smirnov-alexey Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Readiness Checklist

Uh oh!

dmatveev left a comment

Choose a reason for hiding this comment

Uh oh!

dmatveev Dec 3, 2020

Choose a reason for hiding this comment

Uh oh!

TolyaTalamanov Dec 3, 2020

Choose a reason for hiding this comment

Uh oh!

TolyaTalamanov commented Dec 3, 2020

Uh oh!

alalek commented Dec 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TolyaTalamanov commented Dec 4, 2020

Uh oh!

alalek commented Dec 4, 2020

Uh oh!

TolyaTalamanov commented Dec 4, 2020

Uh oh!

alalek commented Dec 4, 2020

Uh oh!

mpashchenkov Dec 7, 2020

Choose a reason for hiding this comment

Uh oh!

smirnov-alexey commented Dec 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smirnov-alexey commented Dec 8, 2020

Uh oh!

alalek commented Dec 8, 2020

Uh oh!

smirnov-alexey commented Dec 8, 2020

Uh oh!

smirnov-alexey commented Dec 8, 2020

Uh oh!

alalek commented Dec 9, 2020

Uh oh!

dmatveev commented Dec 9, 2020

Uh oh!

smirnov-alexey commented Dec 9, 2020

Uh oh!

smirnov-alexey commented Dec 9, 2020

Uh oh!

dmatveev commented Dec 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TolyaTalamanov commented Dec 3, 2020 •

edited by smirnov-alexey

Loading

alalek commented Dec 3, 2020 •

edited

Loading

smirnov-alexey commented Dec 8, 2020 •

edited

Loading