Skip to content

Fix build when HAVE_VULKAN is ON#18973

Merged
alalek merged 2 commits intoopencv:masterfrom
sl-sergei:fix_vulkan_build
Dec 1, 2020
Merged

Fix build when HAVE_VULKAN is ON#18973
alalek merged 2 commits intoopencv:masterfrom
sl-sergei:fix_vulkan_build

Conversation

@sl-sergei
Copy link
Copy Markdown
Contributor

@sl-sergei sl-sergei commented Nov 30, 2020 •
edited by alalek
Loading

My previous PR #18862 was merged to master branch and this created problems with enabled HAVE_VULKAN option, which is not present in 3.4 branch

force_builders=Custom
buildworker:Custom=linux-4
build_image:Custom=ubuntu-vulkan:16.04

@sl-sergei sl-sergei requested review from GArik and alalek November 30, 2020 20:47
alalek
alalek approved these changes Dec 1, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@alalek alalek merged commit 9cef410 into opencv:master Dec 1, 2020
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@sl-sergei
Merge pull request opencv#18973 from sl-sergei:fix_vulkan_build
a47e00c 
* Fix build when HAVE_VULKAN is ON

* Fix warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

+1 more reviewer

@GArik GArik GArik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@GArik GArik

Labels

bug category: build/install category: dnn

Projects

None yet

Milestone

4.5.1

Development

Successfully merging this pull request may close these issues.

3 participants

@sl-sergei @GArik @alalek