Skip to content

[G-API] Multiple return/note fix#18969

Merged
alalek merged 2 commits intoopencv:masterfrom
OrestChura:oc/fix_notes_returns
Dec 8, 2020
Merged

[G-API] Multiple return/note fix#18969
alalek merged 2 commits intoopencv:masterfrom
OrestChura:oc/fix_notes_returns

Conversation

@OrestChura
Copy link
Copy Markdown
Contributor

@OrestChura OrestChura commented Nov 30, 2020 •
edited by alalek
Loading

These changes remove:

  • multiple return
  • multiple notes

relates #18963

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • The feature is well documented and sample code can be built with the project CMake
force_builders_only=linux,docs

@OrestChura
Fix doxygen:
82e7182 
 - multiple return
 - multiple notes
@OrestChura OrestChura requested a review from alalek November 30, 2020 09:26
alalek
alalek reviewed Dec 2, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated documentation.

modules/gapi/include/opencv2/gapi/core.hpp Outdated
@note Function textual ID for merge3 is "org.opencv.core.transform.merge3"
@note Function textual ID for merge4 is "org.opencv.core.transform.merge4"
@note
- Function textual ID for merge3 is "org.opencv.core.transform.merge3"
Copy link
Copy Markdown
Member

@alalek alalek Dec 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no documentation for merge3().

@note ...
@sa merge4

@OrestChura
Addressing comments
3af8554 
 - divide description of split(merge)3/4
@OrestChura OrestChura requested a review from alalek December 8, 2020 00:27
alalek
alalek approved these changes Dec 8, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@alalek alalek merged commit f41327d into opencv:master Dec 8, 2020
@alalek alalek mentioned this pull request Apr 9, 2021
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@OrestChura
Merge pull request opencv#18969 from OrestChura:oc/fix_notes_returns
b22997d 
[G-API] Multiple return/note fix

* Fix doxygen:
 - multiple return
 - multiple notes

* Addressing comments
 - divide description of split(merge)3/4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: documentation Documentation fix or update category: g-api / gapi

Projects

None yet

Milestone

4.5.1

Development

Successfully merging this pull request may close these issues.

2 participants

@OrestChura @alalek