Expose CGImage <-> Mat conversion for iOS platforms#18855
Merged
alalek merged 4 commits intoopencv:masterfrom Nov 19, 2020
Merged
Conversation
a7a2c8c to
1f93b48
Compare
Member
Contributor
|
Thank you @colejd ! Also, regarding the CF_RETURNS_RETAINED annotation, I was not confident in this process, so thank you for adding it. |
Contributor
Author
|
@mtfrctl Thanks! Sorry, I didn't mean to imply any wrongdoing on your part. I should have paid more attention to the file history. Kind of flying by the seat of my pants here. I'll edit the description for clarity. |
Member
|
👍 |
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…ple-conversions-to-framework-builds Expose CGImage <-> Mat conversion for iOS platforms * Add apple_conversions to framework builds This exposes CGImage <-> Mat conversion. * Export Mat <-> CGImage methods on iOS targets * Add CGImage converters to iOS objc helper class * Add CF_RETURNS_RETAINED annotations to methods returning CGImageRef
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#18547 introduces
CGImage<->Matconversion for MacOS platforms. This PR enables the same capabilities for iOS platforms. C++ users can now useMatToCGImageandCGImageToMatinios.h, and Objc users can now do the equivalent conversions inMat+Converters.h.I also took the liberty of adding
CF_RETURNS_RETAINEDannotations to methods that returnCGImageRef, so that the Swift compiler knows toCFRelease()when the reference count goes to 0. This is technically a breaking change, as the prior implementation required users to explicitly usetakeRetainedValue()to properly reference count; however, I think the expectation is that such objects are reference counted by default, so I would categorize the prior behavior as a bug and my changes as a bugfix.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.