G-API: Adding a skip for failed streaming tests by mpashchenkov · Pull Request #18819 · opencv/opencv

mpashchenkov · 2020-11-16T11:14:55Z

Added a skip for failed streaming tests

Tests failed for standalone centOs build.

Case:

try {
    setSource(make_src(dataPath))
} catch(...) {
    skipTest("Warning!")
}

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
The PR is proposed to proper branch
There is reference to original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

Magic centos commands:

force_builders=Custom
build_image:Custom=centos:7
buildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

alalek · 2020-11-16T11:21:09Z

modules/gapi/test/streaming/gapi_streaming_tests.cpp

@@ -35,7 +35,6 @@ void initTestDataPath()
        // Since G-API has no own test data (yet), it is taken from the common space
        const char* testDataPath = getenv("OPENCV_TEST_DATA_PATH");


OPENCV_TEST_DATA_PATH

Do we really need that?
It is already handled by ts module (OpenCV testing framework)

I don't know. Can I get an example or a file where this is used?

https://github.com/opencv/opencv/wiki/QA_in_OpenCV

I looked at the ts.hpp. And findDataFile(call findData) do this step. But i don't understand, how i can to get around addDataSearchPath(...). I can remove initTestDataPath in this case.

alalek · 2020-11-16T11:21:16Z

modules/gapi/test/streaming/gapi_streaming_tests.cpp

 }

 struct GAPI_Streaming: public ::testing::TestWithParam<KernelPackage> {
-    GAPI_Streaming() { initTestDataPath(); }


Why is it copied into tests?

Because i get segfault on my local pc.

Assertion failed) testDataPath != nullptr in function 'initTestDataPath' " thrown in the test fixture's constructor. Segmentation fault (core dumped)

Segfault is here because nobody catched exception.
Need to remove GAPI_Assert(testDataPath != nullptr); line from implementation and make this env variable optional (it make sense to left stdout message).

alalek · 2020-11-16T18:29:58Z

modules/gapi/test/cpu/gapi_ocv_stateful_kernel_tests.cpp

-            GAPI_Assert(testDataPath != nullptr);
-
-            cvtest::addDataSearchPath(testDataPath);
+            cvtest::addDataSearchPath("OPENCV_TEST_DATA_PATH");


Wrong change.

environment variable's name != path

I know. It is my mistake.

alalek · 2020-11-17T13:15:36Z

modules/gapi/test/cpu/gapi_ocv_stateful_kernel_tests.cpp

+    try {
+        ccomp.setSource(gapi::wip::make_src<cv::gapi::wip::GCaptureSource>
+                                   (findDataFile("cv/video/768x576.avi")));
+    } catch(...) {


Please extract findDataFile() call out of this catch "anything" statement.

Fixed for all.

alalek · 2020-11-17T13:18:24Z

modules/gapi/test/cpu/gapi_ocv_stateful_kernel_tests.cpp

            const char* testDataPath = getenv("OPENCV_TEST_DATA_PATH");
-            GAPI_Assert(testDataPath != nullptr);
-
            cvtest::addDataSearchPath(testDataPath);


Assertions are usually used to check assumptions of the code below.

So with removal of assertion you must check/fix the code below:

if (testDataPath) cvtest::addDataSearchPath(testDataPath);

alalek

LGTM

alalek · 2020-11-19T11:13:49Z

BTW, There are 3 cases left to make green the module tests:

[ RUN      ] GraphMeta.Streaming_AccessInput
unknown file: Failure
C++ exception with description "OpenCV(4.5.1-pre) /build/precommit_custom_linux/opencv/modules/gapi/include/opencv2/gapi/streaming/cap.hpp:70: error: (-215:Assertion failed) false && "Couldn't grab the very first frame" in function 'prep'
" thrown in the test body.
[  FAILED  ] GraphMeta.Streaming_AccessInput (0 ms)
[ RUN      ] GraphMeta.Streaming_AccessOutput
unknown file: Failure
C++ exception with description "OpenCV(4.5.1-pre) /build/precommit_custom_linux/opencv/modules/gapi/include/opencv2/gapi/streaming/cap.hpp:70: error: (-215:Assertion failed) false && "Couldn't grab the very first frame" in function 'prep'
" thrown in the test body.
[  FAILED  ] GraphMeta.Streaming_AccessOutput (1 ms)
[ RUN      ] GraphMeta.Streaming_AccessDesync
unknown file: Failure
C++ exception with description "OpenCV(4.5.1-pre) /build/precommit_custom_linux/opencv/modules/gapi/include/opencv2/gapi/streaming/cap.hpp:70: error: (-215:Assertion failed) false && "Couldn't grab the very first frame" in function 'prep'
" thrown in the test body.
[  FAILED  ] GraphMeta.Streaming_AccessDesync (1 ms)

mpashchenkov · 2020-11-19T11:29:29Z

Yes, these tests appeared after merge.

…ntos-tests G-API: Adding a skip for failed streaming tests * Skip tests * Pathfinding * Pathfinding part 2 * Pathfinding part 3 * Fix review comments

mpashchenkov added test category: g-api / gapi labels Nov 16, 2020

alalek reviewed Nov 16, 2020

View reviewed changes

Skip tests

419f101

mpashchenkov force-pushed the mp/ocv-gapi-skip-centos-tests branch from 15a8851 to 419f101 Compare November 17, 2020 08:49

Maxim Pashchenkov added 3 commits November 17, 2020 12:52

Pathfinding

c555ba8

Pathfinding part 2

e62183c

Pathfinding part 3

17a799d

alalek reviewed Nov 17, 2020

View reviewed changes

Fix review comments

345d5ef

alalek approved these changes Nov 17, 2020

View reviewed changes

alalek merged commit 94e8a08 into opencv:master Nov 17, 2020

alalek mentioned this pull request Nov 18, 2020

GAPI: New BackgroundSubtractor stateful kernel #18674

Merged

mpashchenkov mentioned this pull request Nov 23, 2020

G-API: Adding skip for GraphMeta tests #18904

Merged

6 tasks

alalek mentioned this pull request Nov 27, 2020

Merge 4.x #18951

Merged

alalek mentioned this pull request Apr 2, 2021

GAPI test fails on RISC-V #19844

Open

4 tasks

		@@ -35,7 +35,6 @@ void initTestDataPath()
		// Since G-API has no own test data (yet), it is taken from the common space
		const char* testDataPath = getenv("OPENCV_TEST_DATA_PATH");

Uh oh!

Conversation

mpashchenkov commented Nov 16, 2020 • edited by alalek Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Added a skip for failed streaming tests

Pull Request Readiness Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alalek left a comment

Choose a reason for hiding this comment

Uh oh!

alalek commented Nov 19, 2020

Uh oh!

mpashchenkov commented Nov 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mpashchenkov commented Nov 16, 2020 •

edited by alalek

Loading