[G-API]: fitLine() Standard Kernel Implementation by OrestChura · Pull Request #18790 · opencv/opencv

OrestChura · 2020-11-12T17:23:22Z

These changes:

Add fitLine() standard kernel
- provide API and documentation:
  - to support all the original OpenCV functionality, provide two different API (for 2D and 3D points) with several overloads for both (for input cv::GMat, cv::GArray<Point{2,3}i>, cv::GArray<Point{2,3}f>, cv::GArray<Point{2,3}d>)
- support OCV backend
- provide accuracy tests
comparison function for cv::Vec<T, n> provided

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
The PR is proposed to proper branch
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

build_image:Custom=centos:7
buildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

Xbuild_image:Custom=ubuntu-openvino-2020.3.0:16.04
Xbuild_image:Custom Win=openvino-2020.3.0
Xbuild_image:Custom Mac=openvino-2020.3.0

test_modules:Custom=gapi
test_modules:Custom Win=gapi
test_modules:Custom Mac=gapi

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

- initialization for vectors of cv::Point and Mats via vectors added - comparison functions for Vec<T, n> added: - straight average difference comparison - comparison by equasion for 2d line - stream overload for cv::DistanceTypes added

OrestChura · 2020-11-13T13:09:06Z

modules/gapi/test/common/gapi_tests_common.hpp

+        vec_.clear();
+        vec_.reserve(sz_in);
+
+        for (int i = 0; i < sz_in; i++)


There is a warning here:

gapi_tests_common.hpp(339): warning C4702: unreachable code

Could you try to print the values here (sz_in, vec_). There might me an uninitialized value somewhere

@alalek please, could you help with these two problems?

As it is a test code (not a public header), so you can eliminate this warning through #pragma for MSVS 2015 (use _MSC_VER < 1910/*MSVS 2017*/)

OrestChura · 2020-11-13T13:09:40Z

modules/gapi/test/common/gapi_tests_common.hpp

+        {
+            Pt<T> pt;
+            initPointRandU(rng, pt);
+            vec_.push_back(pt);


And here is warning too:

gapi_tests_common.hpp(343): warning C4702: unreachable code

Mb emplace_back, or wrapping (Pt{pt}) might help

mpashchenkov · 2020-11-13T13:10:57Z

modules/gapi/test/common/gapi_tests_common.hpp

+        double _tol;
+};
+
+// class AbsToleranceLine2D : public WrappableVec<AbsToleranceLine2D, float, 4>


Unused code.

modules/gapi/test/common/gapi_tests_common.hpp

modules/gapi/test/cpu/gapi_imgproc_tests_cpu.cpp

modules/gapi/test/common/gapi_tests_common.hpp

smirnov-alexey

Overall looks great, thanks for your effort!

modules/gapi/test/common/gapi_tests_common.hpp

Try to fix warning

smirnov-alexey

Looks good, thanks

mpashchenkov

Ok.

[G-API]: fitLine() Standard Kernel Implementation * fitLine API (Mat, 32S, 32F) (2D, 3D) * Complete fitLine kernel & accuracy tests - initialization for vectors of cv::Point and Mats via vectors added - comparison functions for Vec<T, n> added: - straight average difference comparison - comparison by equasion for 2d line - stream overload for cv::DistanceTypes added * Fix precommit warnings * Fix docs * Address comments Try to fix warning * Disable warning in tests

OrestChura added 2 commits November 11, 2020 21:40

fitLine API (Mat, 32S, 32F) (2D, 3D)

5f53db3

Complete fitLine kernel & accuracy tests

c3ae257

- initialization for vectors of cv::Point and Mats via vectors added - comparison functions for Vec<T, n> added: - straight average difference comparison - comparison by equasion for 2d line - stream overload for cv::DistanceTypes added

OrestChura added test feature category: g-api / gapi labels Nov 12, 2020

OrestChura requested a review from mpashchenkov November 12, 2020 17:23

OrestChura added 2 commits November 12, 2020 23:27

Fix precommit warnings

62eb3f1

Fix docs

768eadc

OrestChura requested a review from smirnov-alexey November 13, 2020 12:29

OrestChura commented Nov 13, 2020

View reviewed changes

mpashchenkov reviewed Nov 13, 2020

View reviewed changes

OrestChura commented Nov 13, 2020

View reviewed changes

modules/gapi/test/common/gapi_tests_common.hpp Outdated Show resolved Hide resolved

smirnov-alexey reviewed Nov 13, 2020

View reviewed changes

modules/gapi/test/common/gapi_tests_common.hpp Outdated Show resolved Hide resolved

smirnov-alexey reviewed Nov 13, 2020

View reviewed changes

modules/gapi/test/cpu/gapi_imgproc_tests_cpu.cpp Outdated Show resolved Hide resolved

smirnov-alexey reviewed Nov 13, 2020

View reviewed changes

modules/gapi/test/common/gapi_tests_common.hpp Show resolved Hide resolved

smirnov-alexey reviewed Nov 13, 2020

View reviewed changes

modules/gapi/test/common/gapi_tests_common.hpp Show resolved Hide resolved

smirnov-alexey requested changes Nov 13, 2020

View reviewed changes

smirnov-alexey reviewed Nov 13, 2020

View reviewed changes

modules/gapi/test/common/gapi_tests_common.hpp Show resolved Hide resolved

Address comments

e43e777

Try to fix warning

smirnov-alexey approved these changes Nov 17, 2020

View reviewed changes

Disable warning in tests

e3e7eba

mpashchenkov approved these changes Nov 17, 2020

View reviewed changes

alalek assigned smirnov-alexey Nov 17, 2020

alalek merged commit 2c6a2f0 into opencv:master Nov 17, 2020

alalek mentioned this pull request Nov 27, 2020

Merge 4.x #18951

Merged

Uh oh!

Conversation

OrestChura commented Nov 12, 2020

Pull Request Readiness Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smirnov-alexey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

smirnov-alexey left a comment

Choose a reason for hiding this comment

Uh oh!

mpashchenkov left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants