stitching: add WAVE_CORRECT_AUTO#18646
Merged
alalek merged 2 commits intoopencv:masterfrom Oct 25, 2020
Merged
Conversation
alalek
reviewed
Oct 24, 2020
| @param rmats Camera rotation matrices. | ||
| @return The correction kind to use for this panorama | ||
| */ | ||
| WaveCorrectKind CV_EXPORTS_W autoDetectWaveCorrectKind(const std::vector<Mat> &rmats); |
Member
There was a problem hiding this comment.
CV_EXPORTS_W
Do we need wrapping this API into Python bindings?
If no, please use just CV_EXPORTS (preferable on a separate line).
CV_EXPORTS
WaveCorrectKind autoDetectWaveCorrectKind(const std::vector<Mat> &rmats);
Contributor
Author
There was a problem hiding this comment.
Done, no need to wrap this
alalek
approved these changes
Oct 25, 2020
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
* stitching: add WAVE_CORRECT_AUTO * stitching: use CV_EXPORTS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
This PR adds a new wave correction kind:
WAVE_CORRECT_AUTO. It will detect the direction (vertical or horizontal) in which the panorama spans, and use that direction for the wave correction algorithm. This enables the usage of wave correction in a generic way.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.