Merged
Conversation
Member
|
Thank you for contribution! Please add simple test for new feature (reuse existed test code and testdata with adding artificial "rectangle" on input like on example). |
Contributor
Author
|
Added the test, I hope it's good enough |
alalek
reviewed
Oct 20, 2020
Member
alalek
left a comment
There was a problem hiding this comment.
Great! Thank you for update 👍
Could you please take a look on comments below.
If you have some issues, then I can prepare proposals in the end of week.
6f25cd7 to
d4a622c
Compare
Contributor
Author
|
I ended up reworking |
alalek
approved these changes
Oct 22, 2020
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
* support similarity masks * add test for similarity threshold * short license in test * use UMat in buildSimilarityMask * fix win32 warnings * fix test indentation * fix umat/mat sync * no in-place argument for erode/dilate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
This PR adds the necessary code to add a similarity mask to the exposure compensator of the stitching pipeline.
You can configure a
similarity_thresholdwhich defines a threshold on the relative error between the pixels of two images. If the error is above the threshold, it is ignored when calculating the exposure compensation. This allows the removal of ghosting artifacts due to exposure compensation when part of the images are different (for instance a moving car which would only be present on a single picture)Note that by default the behavior is unchanged.
Example
The top 2 images are the source images. The bottom left one used a block, per channel exposure compensation. The bottom right used the same, with a similarity threshold of 0.1.
Despite the seam finder and blender doing their job perfectly, the red artifact persists due to the exposure compensator.
The red rectangle has obviously been added artificially but that kind of artifact can exist naturally (example of a moving car above).
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
-> The feature is not documented, but neither are the other features are the exposure compensators. They belong to the
detailnamespace, I guess this is why ?