Skip to content

[G-API] Support ImportNetwork for cv::gapi::infer#18542

Merged
alalek merged 5 commits intoopencv:masterfrom
TolyaTalamanov:at/import-network
Oct 15, 2020
Merged

[G-API] Support ImportNetwork for cv::gapi::infer#18542
alalek merged 5 commits intoopencv:masterfrom
TolyaTalamanov:at/import-network

Conversation

@TolyaTalamanov
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov commented Oct 8, 2020 •
edited by alalek
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

force_builders=ARMv7,Custom
Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
Xbuild_gapi_standalone:Custom=ade-0.1.1f

Xbuild_image:Custom=ubuntu-openvino-2020.4.0:16.04
build_image:Custom=ubuntu-openvino-2021.1.0:20.04
test_modules:Custom=dnn,gapi,python2,python3,java
buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

Xbuild_image:Custom Mac=openvino-2020.4.0
build_image:Custom Mac=openvino-2021.1.0

build_image:Custom Win=openvino-2021.1.0

@TolyaTalamanov TolyaTalamanov force-pushed the at/import-network branch 3 times, most recently from bbc0a33 to b210661 Compare October 8, 2020 14:39
@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Oct 12, 2020

@dmatveev @rgarnov Could you take a look ?

@dmatveev dmatveev self-assigned this Oct 14, 2020
dmatveev
dmatveev reviewed Oct 14, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not as ugly as you explained

modules/gapi/src/backends/ie/giebackend.cpp Outdated
// FIXME: In case importNetwork for fill inputs/outputs need to obtain ExecutableNetwork, but
// for loadNetwork they can be obtained by using readNetwork
mutable IE::ExecutableNetwork this_network;
mutable cv::gimpl::ie::wrap::Plugin this_plugin;
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use const_cast instead

Copy link
Copy Markdown
Contributor

@dmatveev dmatveev Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mutable affects every use, while const_cast is local-to-use.

Copy link
Copy Markdown
Contributor Author

@TolyaTalamanov TolyaTalamanov Oct 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

dmatveev
dmatveev approved these changes Oct 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alalek alalek merged commit 8bf451a into opencv:master Oct 15, 2020
@alalek alalek mentioned this pull request Nov 27, 2020
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@TolyaTalamanov
Merge pull request opencv#18542 from TolyaTalamanov:at/import-network
bf226a0 
[G-API] Support ImportNetwork for cv::gapi::infer

* wip

* Refactoring

* Fix comments to review

* Fix warning

Co-authored-by: Ruslan Garnov <ruslan.garnov@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmatveev dmatveev dmatveev approved these changes

Assignees

@dmatveev dmatveev

Labels

category: g-api / gapi

Projects

None yet

Milestone

4.5.1

Development

Successfully merging this pull request may close these issues.

3 participants

@TolyaTalamanov @dmatveev @alalek