[G-API] Wrap cv::gapi::infer<Generic> into python by TolyaTalamanov · Pull Request #18491 · opencv/opencv

TolyaTalamanov · 2020-10-02T09:19:27Z

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
The PR is proposed to proper branch
There is reference to original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

API example

img = cv.imread('img.png')
g_in = cv.GMat()
inputs = cv.GInferInputs()
inputs.setInput('data', g_in)

outputs = cv.gapi.infer('age-gender', inputs)

age_g = outputs.at('age_conv3')
gender_g = outputs.at('prob')

comp = cv.GComputation(cv.GIn(g_in), cv.GOut(age_g, gender_g))
pp = cv.gapi.ie.params('age-gender', '*.bin', '*.xml', 'CPU')

age, gender = comp.apply(cv.gin(img), args=cv.compile_args(cv.gapi.network(pp)))

Buildbot configuration

build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

force_builders=ARMv7,Custom
Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
Xbuild_gapi_standalone:Custom=ade-0.1.1f

Xbuild_image:Custom=ubuntu-openvino-2020.4.0:16.04
build_image:Custom=ubuntu-openvino-2021.1.0:20.04
test_modules:Custom=gapi,python2,python3,java
buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

Xbuild_image:Custom Mac=openvino-2020.4.0
build_image:Custom Mac=openvino-2021.1.0

build_image:Linux AVX2=ubuntu:20.04

…p-inference

modules/gapi/include/opencv2/gapi/infer.hpp

modules/gapi/misc/python/test/test_gapi_infer.py

…p-inference

alalek · 2020-10-14T22:22:42Z

Please rebase and fix warning from MSVS2019

modules/gapi/include/opencv2/gapi/infer/ie.hpp

…p-inference

TolyaTalamanov · 2020-10-18T09:25:50Z

@dmatveev @alalek

TolyaTalamanov · 2020-10-19T09:45:35Z

@alalek Windows build are green

TolyaTalamanov · 2020-10-22T17:57:31Z

@alalek

modules/gapi/include/opencv2/gapi/infer/ie.hpp

alalek · 2020-10-22T18:11:32Z

modules/gapi/CMakeLists.txt

  ocv_warnings_disable(CMAKE_CXX_FLAGS /wd4503)
+  # FIXME: Unreachable code in Params::backend() (ie.hpp)
+  # https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4702?view=vs-2019
+  ocv_warnings_disable(CMAKE_CXX_FLAGS /wd4702)


ie.hpp

Disabling warnings here would not help users when they start building own applications with G-API public headers.
These settings are private for gapi module only.

It seems I was able to fix that warning in another header... maybe solution like that would work here too.

@TolyaTalamanov Mentioned commit with workaround: 8637b7a

modules/gapi/misc/python/test/test_gapi_infer.py

TolyaTalamanov · 2020-10-26T15:42:05Z

@alalek

alalek · 2020-10-26T19:00:37Z

modules/gapi/include/opencv2/gapi/infer.hpp

@@ -133,31 +133,35 @@ struct InOutInfo
 * @{


@{

Why do we have this here?

/cc @dmatveev

Likely a copy-paste issue, cc: @TolyaTalamanov

alalek

Looks good to me 👍

[G-API] Wrap cv::gapi::infer<Generic> into python * Introduce generic infer * Move Generic to infer.hpp * Removew num_outs * Fix windows warnings * Fix comments to review * Fix doxygen * Add comment * Fix comments to review * Wrap inference to python * Add default ctor to Params * Add test * Fix clang build * Implement GInferInputs/GInferOutputs as Pimpl * Add checkIEtarget to infer test * Fix path * Supress warning * Use getAvailableDevices insted of checkIETarget * Move PyParams to bindings_ie * Add namespace * Update CMakeLists.txt

TolyaTalamanov force-pushed the at/wrap-inference branch from 3491564 to 8782991 Compare October 6, 2020 11:50

TolyaTalamanov added 12 commits October 9, 2020 10:27

Introduce generic infer

f6b2b7b

Move Generic to infer.hpp

043277c

Removew num_outs

d3a9af9

Fix windows warnings

9caecbe

Fix comments to review

f21fe2b

Fix doxygen

4456314

Add comment

2c9ff33

Fix comments to review

a5d970a

Wrap inference to python

2cc0d47

Merge branch 'master' of https://github.com/opencv/opencv into at/wra…

305baa8

…p-inference

Add default ctor to Params

0f9d29d

Add test

cac31fe

TolyaTalamanov force-pushed the at/wrap-inference branch from 8782991 to cac31fe Compare October 12, 2020 14:00

TolyaTalamanov commented Oct 12, 2020

View reviewed changes

modules/gapi/include/opencv2/gapi/infer.hpp Show resolved Hide resolved

dkurt reviewed Oct 13, 2020

View reviewed changes

modules/gapi/misc/python/test/test_gapi_infer.py Outdated Show resolved Hide resolved

dkurt reviewed Oct 13, 2020

View reviewed changes

modules/gapi/misc/python/test/test_gapi_infer.py Outdated Show resolved Hide resolved

TolyaTalamanov force-pushed the at/wrap-inference branch from e8ea54f to 3cd12b4 Compare October 13, 2020 09:55

Merge branch 'master' of https://github.com/opencv/opencv into at/wra…

9755e84

…p-inference

TolyaTalamanov force-pushed the at/wrap-inference branch from 3cd12b4 to 9755e84 Compare October 13, 2020 12:03

TolyaTalamanov added 4 commits October 14, 2020 13:58

Fix clang build

fdc6193

Implement GInferInputs/GInferOutputs as Pimpl

bcf88cc

Add checkIEtarget to infer test

661deea

Fix path

2d30256

dkurt reviewed Oct 15, 2020

View reviewed changes

modules/gapi/include/opencv2/gapi/infer/ie.hpp Outdated Show resolved Hide resolved

TolyaTalamanov added 2 commits October 16, 2020 12:43

Merge branch 'master' of https://github.com/opencv/opencv into at/wra…

8431195

…p-inference

Supress warning

6e61014

alalek reviewed Oct 22, 2020

View reviewed changes

TolyaTalamanov added 3 commits October 26, 2020 12:24

Use getAvailableDevices insted of checkIETarget

a2abb91

Move PyParams to bindings_ie

44a4cb7

Add namespace

647c2d2

Update CMakeLists.txt

2adb788

alalek reviewed Oct 26, 2020

View reviewed changes

alalek approved these changes Oct 26, 2020

View reviewed changes

alalek merged commit 93c3775 into opencv:master Oct 26, 2020

alalek mentioned this pull request Nov 27, 2020

Merge 4.x #18951

Merged

Uh oh!

Conversation

TolyaTalamanov commented Oct 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Readiness Checklist

API example

Buildbot configuration

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alalek commented Oct 14, 2020

Uh oh!

Uh oh!

TolyaTalamanov commented Oct 18, 2020

Uh oh!

TolyaTalamanov commented Oct 19, 2020

Uh oh!

TolyaTalamanov commented Oct 22, 2020

Uh oh!

Uh oh!

alalek Oct 22, 2020

Choose a reason for hiding this comment

Uh oh!

dmatveev Oct 23, 2020

Choose a reason for hiding this comment

Uh oh!

alalek Oct 26, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TolyaTalamanov commented Oct 26, 2020

Uh oh!

alalek Oct 26, 2020

Choose a reason for hiding this comment

Uh oh!

dmatveev Oct 26, 2020

Choose a reason for hiding this comment

Uh oh!

alalek left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TolyaTalamanov commented Oct 2, 2020 •

edited

Loading