Skip to content

add HEVC(H.265) codec to iOS,Mac VideoWriter#18426

Merged
alalek merged 4 commits intoopencv:masterfrom
Varvrar:add-HEVC-codec-iOS-Mac
Oct 19, 2020
Merged

add HEVC(H.265) codec to iOS,Mac VideoWriter#18426
alalek merged 4 commits intoopencv:masterfrom
Varvrar:add-HEVC-codec-iOS-Mac

Conversation

@Varvrar
Copy link
Copy Markdown
Contributor

@Varvrar Varvrar commented Sep 25, 2020 •
edited
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

alalek
alalek reviewed Sep 25, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution!

Varvrar and others added 3 commits September 28, 2020 17:10
@Varvrar
Update cap_avfoundation_mac.mm
82568b0 
add CV_FOURCC('h','v','c','1') for HEVC codec
@Varvrar
Update cap_avfoundation.mm
22c77bc 
add CV_FOURCC('h','v','c','1') for HEVC codec
@VadimLevin
feat: add availability check for HEVC codec on iOS and OS X
b641e3c
@VadimLevin
Copy link
Copy Markdown
Contributor

VadimLevin commented Oct 19, 2020

I added required versions checks based on the availability of the HEVC key in the AVVideoSettings.h:43:

AVF_EXPORT AVVideoCodecType const AVVideoCodecTypeHEVC /* @"hvc1" */                    API_AVAILABLE(macos(10.13), ios(11.0), tvos(11.0)) API_UNAVAILABLE(watchos);

@alalek Can you proceed with review, please?

@alalek
Copy link
Copy Markdown
Member

alalek commented Oct 19, 2020

@VadimLevin Great! Thank you 👍

@alalek alalek merged commit b87f7a6 into opencv:master Oct 19, 2020
@alalek alalek mentioned this pull request Nov 27, 2020
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@Varvrar @VadimLevin
Merge pull request opencv#18426 from Varvrar:add-HEVC-codec-iOS-Mac
a805c1d 
* add HEVC(H.265) codec to iOS,Mac VideoWriter

* Update cap_avfoundation_mac.mm

add CV_FOURCC('h','v','c','1') for HEVC codec

* Update cap_avfoundation.mm

add CV_FOURCC('h','v','c','1') for HEVC codec

* feat: add availability check for HEVC codec on iOS and OS X

Co-authored-by: Vadim Levin <vadim.levin@xperience.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

feature platform: ios/osx

Projects

None yet

Milestone

4.5.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Varvrar @VadimLevin @alalek