Skip to content

[G-API] Introduce generic version for cv::gapi::infer#18419

Merged
alalek merged 10 commits intoopencv:masterfrom
TolyaTalamanov:at/generic-inference
Oct 8, 2020
Merged

[G-API] Introduce generic version for cv::gapi::infer#18419
alalek merged 10 commits intoopencv:masterfrom
TolyaTalamanov:at/generic-inference

Conversation

@TolyaTalamanov
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov commented Sep 25, 2020 •
edited by alalek
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Buildbot configuration

build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

force_builders=ARMv7,Custom
Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
Xbuild_gapi_standalone:Custom=ade-0.1.1f

Xbuild_image:Custom=ubuntu-openvino-2020.4.0:16.04
build_image:Custom=ubuntu-openvino-2021.1.0:20.04
test_modules:Custom=gapi,python2,python3,java
buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

Xbuild_image:Custom Mac=openvino-2020.4.0
build_image:Custom Mac=openvino-2021.1.0

build_image:Linux AVX2=ubuntu:20.04

@TolyaTalamanov TolyaTalamanov force-pushed the at/generic-inference branch 5 times, most recently from a0905f4 to 9420006 Compare September 29, 2020 13:22
@TolyaTalamanov TolyaTalamanov changed the title [WIP][G-API] Introduce generic version for cv::gapi::infer [G-API] Introduce generic version for cv::gapi::infer Sep 29, 2020
@TolyaTalamanov TolyaTalamanov force-pushed the at/generic-inference branch 4 times, most recently from ea12c11 to cf4b491 Compare September 29, 2020 13:28
@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Sep 29, 2020

@dmatveev Could you have a look, please ?

@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Sep 30, 2020

@dmatveev

TolyaTalamanov
TolyaTalamanov commented Sep 30, 2020
View reviewed changes
TolyaTalamanov
TolyaTalamanov commented Sep 30, 2020
View reviewed changes
TolyaTalamanov
TolyaTalamanov commented Sep 30, 2020
View reviewed changes
TolyaTalamanov
TolyaTalamanov commented Sep 30, 2020
View reviewed changes
@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Sep 30, 2020

FYI python bridge: https://github.com/TolyaTalamanov/opencv/pull/6/files

dmatveev
dmatveev reviewed Sep 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structurally it is ok, but changes like this require a thorough documentation.

@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Oct 1, 2020

@dmatveev

@dmatveev
Copy link
Copy Markdown
Contributor

dmatveev commented Oct 1, 2020

@TolyaTalamanov I see parts of the comments is addressed, what about the rest? Please signal what's the decision there.

@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Oct 2, 2020

@dmatveev

@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Oct 5, 2020

@dmatveev

@dmatveev
Copy link
Copy Markdown
Contributor

dmatveev commented Oct 5, 2020

@TolyaTalamanov I am not sure if my above open comments were addressed. Please reply. I won't be verifying it on my own.

@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Oct 6, 2020

@dmatveev

dmatveev
dmatveev approved these changes Oct 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Approved, Thanks!

@dmatveev dmatveev self-assigned this Oct 7, 2020
@dmatveev dmatveev added this to the 4.5.0 milestone Oct 7, 2020
@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Oct 7, 2020

@alalek

@alalek
Copy link
Copy Markdown
Member

alalek commented Oct 7, 2020

Added builds with OpenVINO shows failure of added test.

@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Oct 8, 2020

@alalek Thanks! now all tests are passed

@alalek alalek merged commit 76be352 into opencv:master Oct 8, 2020
@alalek alalek mentioned this pull request Nov 27, 2020
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@TolyaTalamanov
Merge pull request opencv#18419 from TolyaTalamanov:at/generic-inference
2555e26 
[G-API] Introduce generic version for cv::gapi::infer

* Introduce generic infer

* Move Generic to infer.hpp

* Removew num_outs

* Fix windows warnings

* Fix comments to review

* Fix doxygen

* Add comment

* Fix comments to review

* standoalone ifdef in ginfer.cpp

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmatveev dmatveev dmatveev approved these changes

Assignees

@dmatveev dmatveev

Labels

category: g-api / gapi

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@TolyaTalamanov @dmatveev @alalek