Merged
Conversation
alalek
reviewed
Sep 13, 2020
3rdparty/libtengine/tengine.cmake
Outdated
| SET (TENGINE_TOOLCHIN_FLAG "-march=armv7-a") | ||
| elseif(CMAKE_SYSTEM_PROCESSOR STREQUAL aarch64) ## AARCH64 | ||
| SET(CONFIG_ARCH_ARM64 ON) | ||
| SET (TENGINE_TOOLCHIN_FLAG "-march=armv8-a") |
modules/dnn/src/dnn.cpp
Outdated
| LayerData &ld = it->second; | ||
| Ptr<Layer> layerCur = ld.layerInstance; | ||
|
|
||
| if (!strcmp(ld.type.c_str(),"Convolution")) |
Member
There was a problem hiding this comment.
Why Layer::finalize() doesn't work here?
(or just the first run of Layer::forward(), check integration of convolutionOp from OpenCL backend)
Contributor
Author
There was a problem hiding this comment.
Move to Layer::forward . please checkout again
alalek
reviewed
Sep 17, 2020
3rdparty/libtengine/tengine.cmake
Outdated
| SET (TENGINE_TOOLCHAIN_FLAG "-march=armv7-a") | ||
| elseif(CMAKE_SYSTEM_PROCESSOR STREQUAL aarch64) ## AARCH64 | ||
| SET(CONFIG_ARCH_ARM64 ON) | ||
| SET (TENGINE_TOOLCHAIN_FLAG "-march=armv8-a") |
modules/dnn/CMakeLists.txt
Outdated
| if(EXISTS ${TENGINE_LIBRARIES}) | ||
| list(APPEND libs ${TENGINE_LIBRARIES}) | ||
| if(EXISTS ${TENGINE_LIBRARIES}) | ||
| list(APPEND libs -Wl,--whole-archive ${TENGINE_LIBRARIES} -Wl,--no-whole-archive) |
Member
There was a problem hiding this comment.
if(EXISTS ${TENGINE_LIBRARIES})
Don't work with list as variable value.
Broken indentation.
No difference between both code paths. ocv_add_dependencies() is misused (required opencv modules) and does nothing.
added 3 commits
September 21, 2020 16:13
alalek
reviewed
Sep 21, 2020
3rdparty/libtengine/tengine.cmake
Outdated
| SET(OCV_TENGINE_URL "https://github.com/OAID/Tengine/archive/") #url2 | ||
| SET(tengine_md5sum f51ca8f3963faeeff3f019a6f6edc206) #md5sum2 | ||
| #SET(OCV_TENGINE_URL "https://github.com/OAID/Tengine/archive/") #url2 | ||
| SET(OCV_TENGINE_URL "https://github.com/liqi-c/Tengine/archive/") #url2. Tmp url |
Member
There was a problem hiding this comment.
You don't need that for testing. Upstream URL should work fine with commits from fork.
alalek
approved these changes
Sep 23, 2020
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
Tengine lite update * update tengine * Modify for arm32 build. * format optimization * add teng_ befor some tengine api * update graph_t to teng_graph_t * update graph_t to teng_graph_t * Code structure optimization * optimization * optimization * remove space * update tengine url Co-authored-by: liqi <qli@openailab.com>
6 tasks
asmorkalov
pushed a commit
that referenced
this pull request
Aug 9, 2023
dnn: cleanup of tengine backend #24122 🚀 Cleanup for OpenCV 5.0. Tengine backend is added for convolution layer speedup on ARM CPUs, but it is not maintained and the convolution layer on our default backend has reached similar performance to that of Tengine. Tengine backend related PRs: - #16724 - #18323 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
Jan 4, 2024
dnn: cleanup of tengine backend opencv#24122 🚀 Cleanup for OpenCV 5.0. Tengine backend is added for convolution layer speedup on ARM CPUs, but it is not maintained and the convolution layer on our default backend has reached similar performance to that of Tengine. Tengine backend related PRs: - opencv#16724 - opencv#18323 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
May 29, 2024
dnn: cleanup of tengine backend opencv#24122 🚀 Cleanup for OpenCV 5.0. Tengine backend is added for convolution layer speedup on ARM CPUs, but it is not maintained and the convolution layer on our default backend has reached similar performance to that of Tengine. Tengine backend related PRs: - opencv#16724 - opencv#18323 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.