Add broken implementation note for DLS and UPnP#18171
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Aug 25, 2020
Merged
Add broken implementation note for DLS and UPnP#18171opencv-pushbot merged 1 commit intoopencv:3.4from
opencv-pushbot merged 1 commit intoopencv:3.4from
Conversation
alalek
reviewed
Aug 23, 2020
| SOLVEPNP_DLS = 3, //!< A Direct Least-Squares (DLS) Method for PnP @cite hesch2011direct | ||
| SOLVEPNP_UPNP = 4, //!< Exhaustive Linearization for Robust Camera Pose and Focal Length Estimation @cite penate2013exhaustive | ||
| SOLVEPNP_DLS = 3, //!< <b> Broken implementation. Using this flag will fallback to EPnP. </b> | ||
| //!< <del> A Direct Least-Squares (DLS) Method for PnP @cite hesch2011direct </del> |
Member
There was a problem hiding this comment.
calib3d/include/opencv2/calib3d.hpp:454: warning: Unsupported xml/html tag <del> found
Can we use @note here instead?
Related SO question: https://stackoverflow.com/questions/27827966/how-can-i-use-strikethrough-in-the-doxygens-markdown
Contributor
Author
There was a problem hiding this comment.
I have replaced <del> with ~~. Let see if it works.
Contributor
Author
There was a problem hiding this comment.
Looks like strikethrough is not correctly rendered with the version of Doxygen on the CI. I will update to remove it.
Add CV_LOG_DEBUG.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
This is 5 years too late in my opinion.
See #5065 and #6864 (comment)