Reactivating SOLVEPNP_DLS and SOLVEPNP_UPNP#6864
Closed
mshabunin wants to merge 1 commit intoopencv:masterfrom
Closed
Reactivating SOLVEPNP_DLS and SOLVEPNP_UPNP#6864mshabunin wants to merge 1 commit intoopencv:masterfrom
mshabunin wants to merge 1 commit intoopencv:masterfrom
Conversation
They have been silently deactivated because of their poor performance. Reactivate them to give incentives for improvement
Contributor
|
the other methods appeared to be unstable and sometimes give completely wrong results; they will be restored when someone fixes them |
|
Sorry to revive this one. Would you be in favor of throwing a warning to let the user know that invoking DLS or UPNP doesn't produce the desired result? I literally just fell on what @mshabunin described: trying to compare solvers only to discover that under the hood, EPnP is always being called. |
6 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way how uPnP and DLS have been disabled in #3828 is highly counter-intuitive:
Just executing EPNP regardless of the given flag is confusing. If somebody wants to evaluate the OpenCV version of uPnP, let him do that (and not silently executing epnp in the background). Imagine somebody wants to evaluate the available PnP solvers in OpenCV and finds out that it does not matter which one he chooses because the results are all the same.
cf. #5065
Restored #5978