QR code (encoding process) by ZhengQiushi · Pull Request #17889 · opencv/opencv

ZhengQiushi · 2020-07-20T04:33:23Z

Merge with extra: opencv/opencv_extra#807

ISO standard and wiki useful information.

modules/objdetect/src/qrcode.cpp

ZhengQiushi · 2020-07-30T03:00:17Z

Thanks for your suggestions.+decode_error QRDecode::read_format(uint16_t& format , int which){ + /*version<=6*/ + int i; + uint16_t my_format = 0; + + Mat mat_format(1,FORMAT_LENGTH,CV_8UC1,Scalar(0));\I use cv::Mat only because it is easy to print by using "std::cout". And I did not add the usage in my code(I forget that...). I will add that later.

…

------------------ Original ------------------ From: "ann"<notifications@github.com>; Date: 2020年7月30日(星期四) 凌晨3:02 To: "opencv/opencv"<opencv@noreply.github.com>; Cc: "413366511"<woaiwo6666@qq.com>; "Author"<author@noreply.github.com>; Subject: Re: [opencv/opencv] WIP：QR code (decoding process) (#17889) @APrigarina commented on this pull request. In modules/objdetect/src/qrcode.cpp: > +#define MAX_VERSION 40 +#define MAX_ALIGNMENT 7 These macros are already defined above In modules/objdetect/src/qrcode.cpp: > vector<Point2f> original_points; + + uint8_t orignal_data[MAX_PAYLOAD]; + uint8_t rearranged_data[MAX_PAYLOAD]; + uint8_t final[MAX_PAYLOAD]; it's not recommended to use keywords for variable names In modules/objdetect/src/qrcode.cpp: > + memset(final,0,sizeof(uint8_t)*MAX_PAYLOAD); + memset(payload,0,sizeof(uint8_t)*MAX_PAYLOAD); + payload_len=0; +} + +/* + * params @ format(uint16_t for returning the format bits) which(select from two different place) + * return @ can be correct or not + */ + +decode_error QRDecode::read_format(uint16_t& format , int which){ + /*version<=6*/ + int i; + uint16_t my_format = 0; + + Mat mat_format(1,FORMAT_LENGTH,CV_8UC1,Scalar(0)); what is the reason of use cv::Mat instead of std::vector and how is this variable used? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

modules/objdetect/src/qrcode.cpp

rayonnant14 · 2020-09-04T12:55:56Z

modules/objdetect/src/qrcode.cpp

+    version_index = -1;
+    /**find the version according to the number of data codewords*/
+    for( i = version_begin ; i < version_end ; i++ ){
+        const BlockParams * tmp_ecc_params = &(version_info_database[i].ecc[ecc_level]);


Are you really need pointer in this case?
It is good way if you avoid pointers

I think pointers maybe take less space and can be used in a faster way, (although may be not that safe..

you can use shared pointers

I find that I can't 'make' normally when I use "share_ptr".It says " error: ‘shared_ptr’ in namespace ‘std’ does not name a template type
std::shared_ptr version_info ;
"
So what should I do now ? Looking forword to your help!

/home/truth/github/opencv/modules/objdetect/src/qrcode.cpp:2290:10: error: ‘shared_ptr’ in namespace ‘std’ does not name a template type
std::shared_ptr version_info ;

you can try smart pointers in opencv (here)

modules/objdetect/src/qrcode.cpp

modules/ts/include/opencv2/ts/ts_gtest.h

modules/objdetect/include/opencv2/objdetect.hpp

modules/objdetect/src/qrcode.cpp

modules/objdetect/test/test_qrcode_decode_encode.cpp

modules/objdetect/include/opencv2/objdetect.hpp

modules/objdetect/test/test_qrcode_decode_encode.cpp

modules/objdetect/src/qrcode.cpp

modules/objdetect/test/test_qrcode.cpp

modules/objdetect/include/opencv2/objdetect.hpp

modules/objdetect/test/test_qrcode_decode_encode.cpp

ZhengQiushi · 2020-10-03T12:29:41Z

I don't think it is necessary to use smart pointers here, because they are pointing to static variables and are not involved with memory allocation and free. So can I just use the normal pointers?

…

------------------ 原始邮件 ------------------ 发件人: "ann"<notifications@github.com>; 发送时间: 2020年9月28日(星期一) 晚上8:33 收件人: "opencv/opencv"<opencv@noreply.github.com>; 抄送: "413366511"<woaiwo6666@qq.com>; "Mention"<mention@noreply.github.com>; 主题: Re: [opencv/opencv] WIP：QR code (decoding process) (#17889) @APrigarina commented on this pull request. In modules/objdetect/src/qrcode.cpp: > + int versionAuto(const std::string & input_str); + +}; +/**findVersionCapacity + * @param input_length + * @param ecc_level + * @param mode + * @func find the version automatically + * @return the version index + * */ +int findVersionCapacity(const int &input_length ,const int &ecc_level ,const int & version_begin, const int & version_end ){ + int i,version_index,data_codewords; + version_index = -1; + /**find the version according to the number of data codewords*/ + for( i = version_begin ; i < version_end ; i++ ){ + const BlockParams * tmp_ecc_params = &(version_info_database[i].ecc[ecc_level]); you can try smart pointers in opencv (here) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

asmorkalov · 2020-11-30T10:40:21Z

@ZhengQiushi Do you have any progress with the patch? The PR still does not pass CI checks.

rayonnant14 · 2020-11-30T13:15:49Z

@ZhengQiushi Do you have any progress with the patch? The PR still does not pass CI checks.

Hi, @asmorkalov. At the moment, I and @APrigarina are working on this PR. Some QR codes modes don't work correctly, we are trying to fix it

asenyaev · 2021-04-08T21:50:56Z

jenkins cn please retry a build

APrigarina · 2021-05-13T11:03:10Z

@allnes, @rayonnant14 please review

rayonnant14 · 2021-05-31T21:36:39Z

modules/objdetect/src/qrcode_encoder.cpp

+    fnc1_first = false;
+    fnc1_second = false;
+    fnc1_second_AI = 0;


These variables are not used

rayonnant14 · 2021-05-31T21:42:42Z

modules/objdetect/src/qrcode_encoder.cpp

+    std::string counter = decToBin(str_len, bits);
+    loadString(counter, output, true);
+    int i;
+    for (i = 0; i < str_len; i += 2)


Suggested change

for (i = 0; i < str_len; i += 2)

for (i = 0; i < str_len - 1; i += 2)

alalek

@APrigarina Thank you for update!

Could you please add links/information somewhere about used format specification?

alalek · 2021-06-17T07:11:17Z

modules/objdetect/include/opencv2/objdetect.hpp

+                          int version = 0, int correction_level = CORRECT_LEVEL_L,
+                          int mode = QR_MODE_AUTO, int structure_number = 1,


Parameters should be split on 2 parts:

properties of algorithm - should go into constructor/create() methods

sample processing properties (output_size)

This is useful to unify algorithms and provide one interface.

alalek · 2021-06-17T07:14:40Z

modules/objdetect/include/opencv2/objdetect.hpp

+     @param structure_number The optional number of QR codes to generate in Structured Append mode.
+     @param output_size The optional size of generated QR code (by default is small and depends on version).
+    */
+    CV_WRAP bool generate(String input, OutputArray  output,


generate => encode

remove unnecessary double spaces.

alalek · 2021-06-17T07:15:38Z

modules/objdetect/src/qrcode_encoder.cpp

+
+#include "precomp.hpp"
+#include "opencv2/objdetect.hpp"
+#include "opencv2/calib3d.hpp"


Why do we need calib3d?

alalek · 2021-06-17T07:17:11Z

modules/objdetect/src/qrcode_encoder.cpp

+#include "precomp.hpp"
+#include "opencv2/objdetect.hpp"
+#include "opencv2/calib3d.hpp"
+#include <iostream>


iostream

should not be used in OpenCV modules.
Use logging instead.
Or properly target headers, like sstream.

alalek · 2021-06-17T07:18:12Z

modules/objdetect/src/qrcode_encoder.cpp

+std::string decToBin(const int &format, const int &total);
+int eccLevelToCode(int level);
+uint8_t gfPow(uint8_t x, int power);
+uint8_t gfMul(const uint8_t& x, const uint8_t& y);
+Mat gfPolyMul(const Mat& p, const Mat& q);
+Mat gfPolyDiv(const Mat& dividend, const Mat& divisor, const int& ecc_num);
+Mat polyGenerator(const int& n);
+int getBits(const int& bits, const vector<uint8_t>& payload ,int& pay_index);
+void loadString(const std::string& str, vector<uint8_t>& cur_str, bool is_bit_stream);


static to make them local

alalek · 2021-06-17T08:01:07Z

modules/objdetect/src/qrcode_encoder.cpp

+QRCodeEncoder::QRCodeEncoder() : p(new Impl) {}
+QRCodeEncoder::~QRCodeEncoder() {}
+
+bool QRCodeEncoder::generate(cv::String input, cv::OutputArray output,


bool result is not informative from the user perspective.

How to troubleshot the false result?

cv::

should be removed.

alalek · 2021-06-17T08:04:03Z

modules/objdetect/test/test_qrcode_encode.cpp

+                return; // done
+            }
+        }
+        std::cerr


FAIL() <<

alalek · 2021-06-17T08:05:43Z

modules/objdetect/test/test_qrcode_encode.cpp

+                QRCodeEncoder encoder;
+                Mat result ;
+                bool success = encoder.generate(original_info, result);
+                ASSERT_TRUE(success) << "Can't generate qr image :" << name_test_image;


<< name_test_image

not necessary as this is a test parameter.

alalek · 2021-06-17T08:06:55Z

modules/objdetect/test/test_qrcode_encode.cpp

+                Mat src = imread(image_path, IMREAD_GRAYSCALE), straight_barcode;
+                ASSERT_FALSE(src.empty()) << "Can't read image: " << image_path;
+
+                bool eq = countDiffPixels(result, src) == 0;


NORM_L1 or _INF

alalek · 2021-06-17T08:10:11Z

modules/objdetect/test/test_qrcode_encode.cpp

+        std::string image_path = findDataFile(root +"/"+ encode_qrcode_images_name[i]);
+
+        /**read from test set*/
+        Mat src = imread(image_path, IMREAD_GRAYSCALE), straight_barcode;


straight_barcode

Avoid multiple declarations on the single line (allowed for simple cases without initialization only).
Must be defined near its usage.

APrigarina · 2021-06-17T08:36:54Z

@APrigarina Thank you for update!

Could you please add links/information somewhere about used format specification?

Sure, here is ISO standard and wiki useful information

APrigarina · 2021-08-25T12:03:11Z

@alalek Please review

alalek · 2021-08-28T00:07:42Z

modules/objdetect/include/opencv2/objdetect.hpp

+     @param encoded_info Input string to encode.
+     @param qrcode Generated QR code.
+    */
+    CV_WRAP virtual void encode(String encoded_info, OutputArray qrcode) = 0;


String

"const reference"

const String& should be used for input parameters.

here and below

alalek · 2021-08-28T00:08:45Z

modules/objdetect/src/qrcode_encoder.cpp

+    output_bits.insert(output_bits.end(), bin_number.begin(), bin_number.end());
+}
+
+static int eccLevelToCode(int level)


int => QRCodeCorrectionLevel

alalek · 2021-08-28T00:09:57Z

modules/objdetect/test/test_qrcode_encode.cpp

+    size_t mode_count = static_cast<size_t>(mode_list.size());
+    ASSERT_GT(mode_count, 0u) << "Can't find validation data entries in 'test_images': " << dataset_config;
+
+    int modes[] = {1, 2, 4};


magic numbers or QREncodeMode?

alalek · 2021-08-28T00:10:51Z

modules/objdetect/include/opencv2/objdetect.hpp

+        CV_WRAP Params();
+        CV_PROP_RW int version;
+        CV_PROP_RW int correction_level;
+        CV_PROP_RW int mode;


int correction_level
int mode

Can we use enums here?

alalek · 2021-08-28T00:12:03Z

modules/objdetect/test/test_qrcode_encode.cpp

+const Size fixed_size = Size(200, 200);
+const float border_width = 2.0;
+
+int establishCapacity(int mode, int version, int capacity)


int mode

Please use enum type

alalek · 2021-08-28T00:35:26Z

modules/objdetect/src/qrcode_encoder.cpp

+    EncodingMethods result = strategy[strategy.size() - 1];
+    for (size_t i = 0; i < result.blocks.size(); i++)
+    {
+        AutoEncodePerBlock result_block = result.blocks[i];


EncodingMethods result
AutoEncodePerBlock result_block

reference or const reference

alalek · 2021-08-28T00:38:18Z

modules/objdetect/src/qrcode_encoder.cpp

+            for (size_t j = 0; j < str_len; j++)
+            {
+                previous = strategy[j];
+                std::string sub_string = cur_string.substr(j, str_len - j);


.substr(j, str_len - j)

The second argument is not needed here: https://en.cppreference.com/w/cpp/string/basic_string/substr

alalek · 2021-08-28T00:40:02Z

modules/objdetect/src/qrcode_encoder.cpp

+            EncodingMethods previous;
+            EncodingMethods new_method;
+            new_method.len = ERROR_MODE_OCCUR;
+            for (size_t j = 0; j < str_len; j++)
+            {
+                previous = strategy[j];


EncodingMethods previous;

Not used outside of for body, so it should be declated inside.

alalek · 2021-08-28T00:41:03Z

modules/objdetect/src/qrcode_encoder.cpp

+        }
+        else
+        {
+            size_t str_len = cur_string.length();


cur_string.length() should be equal to i.

alalek · 2021-08-28T00:52:31Z

modules/objdetect/include/opencv2/objdetect.hpp

+enum ECIEncodings {
+    ECI_UTF8 = 26
+};


alalek

Looks good to me

alalek · 2021-11-02T12:31:16Z

modules/objdetect/src/qrcode_encoder.cpp

+        ecc_level = parameters.correction_level;
+        mode_type = parameters.mode;
+        struct_num = parameters.structure_number;
+    }


not all variables are initialized in ctor:

int version_size; int mask_type; uint32_t eci_assignment_number; uint8_t parity; uint8_t sequence_num; uint8_t total_num;

alalek · 2021-11-02T12:34:09Z

modules/objdetect/include/opencv2/objdetect.hpp

+     @param encoded_info Input string to encode.
+     @param qrcode Generated QR code.
+    */
+    CV_WRAP virtual void encode(String encoded_info, OutputArray qrcode) = 0;


const String& should be used for input parameters.

here and below

alalek

@APrigarina Great job!

ZhengQiushi changed the title ~~WIP：complete the process of correcting the blocks~~ WIP：QR code (decoding process) Jul 29, 2020

APrigarina reviewed Jul 29, 2020

View reviewed changes

modules/objdetect/src/qrcode.cpp Outdated Show resolved Hide resolved

modules/objdetect/src/qrcode.cpp Outdated Show resolved Hide resolved

modules/objdetect/src/qrcode.cpp Outdated Show resolved Hide resolved

asmorkalov added the category: objdetect label Aug 3, 2020

asmorkalov added the GSoC label Aug 21, 2020

allnes reviewed Aug 24, 2020

View reviewed changes

allnes reviewed Aug 27, 2020

View reviewed changes

APrigarina reviewed Aug 31, 2020

View reviewed changes

rayonnant14 reviewed Sep 4, 2020

View reviewed changes

allnes reviewed Sep 10, 2020

View reviewed changes

rayonnant14 reviewed Sep 14, 2020

View reviewed changes

APrigarina reviewed Sep 17, 2020

View reviewed changes

rayonnant14 reviewed Sep 17, 2020

View reviewed changes

modules/objdetect/src/qrcode.cpp Outdated Show resolved Hide resolved

modules/objdetect/src/qrcode.cpp Outdated Show resolved Hide resolved

rayonnant14 reviewed Sep 17, 2020

View reviewed changes

modules/objdetect/test/test_qrcode.cpp Outdated Show resolved Hide resolved

allnes reviewed Sep 21, 2020

View reviewed changes

APrigarina force-pushed the my_3.4 branch 2 times, most recently from f55c4bb to d650c14 Compare May 6, 2021 13:25

add qrcode encoder

8316206

APrigarina force-pushed the my_3.4 branch from c581151 to 8316206 Compare May 13, 2021 10:18

rayonnant14 reviewed May 31, 2021

View reviewed changes

qr encoder fixes

5b53731

APrigarina force-pushed the my_3.4 branch from 6ab7060 to 5b53731 Compare June 16, 2021 17:27

alalek reviewed Jun 17, 2021

View reviewed changes

APrigarina force-pushed the my_3.4 branch from 57600b9 to 1e13346 Compare July 11, 2021 21:19

qr encoder: fix api and realization

2663910

APrigarina force-pushed the my_3.4 branch 2 times, most recently from c6ca15a to 2663910 Compare July 11, 2021 22:01

APrigarina force-pushed the my_3.4 branch from dfe3148 to cca1730 Compare August 24, 2021 21:13

alalek reviewed Sep 10, 2021

View reviewed changes

APrigarina force-pushed the my_3.4 branch from cca1730 to 2313f6f Compare October 6, 2021 15:04

fixed qr encoder, added eci and kanji modes

dd7334d

APrigarina force-pushed the my_3.4 branch from 2313f6f to dd7334d Compare October 7, 2021 20:59

trigger CI

e133672

alalek reviewed Nov 2, 2021

View reviewed changes

qr encoder constructor fixes

76146c3

APrigarina force-pushed the my_3.4 branch from d7fe83e to 76146c3 Compare November 15, 2021 09:19

alalek approved these changes Nov 15, 2021

View reviewed changes

alalek merged commit 3e51448 into opencv:3.4 Nov 15, 2021

This was referenced Nov 20, 2021

(4.x) Merge 3.4 #21091

Merged

QRcode: valgrind issues (2021-11-21) #21098

Closed

alalek mentioned this pull request Dec 30, 2021

(5.x) Merge 4.x #21371

Merged

alalek mentioned this pull request Feb 22, 2022

(5.x) Merge 4.x #21651

Merged

alalek mentioned this pull request Jan 6, 2023

Implement QR Code decoder and encoder #17290

Closed

4 tasks

dkurt mentioned this pull request Sep 6, 2023

QRCodes decoding without Quirc #24225

Closed

5 tasks

	for (i = 0; i < str_len; i += 2)
	for (i = 0; i < str_len - 1; i += 2)

		int version = 0, int correction_level = CORRECT_LEVEL_L,
		int mode = QR_MODE_AUTO, int structure_number = 1,

Uh oh!

Conversation

ZhengQiushi commented Jul 20, 2020 • edited by alalek Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ZhengQiushi commented Jul 30, 2020 via email

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ZhengQiushi commented Jul 20, 2020 •

edited by alalek

Loading