Skip to content

videoio/MSMF: fixed audio stream handling#17406

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
mshabunin:fix-msmf-audio-handling
May 27, 2020
Merged

videoio/MSMF: fixed audio stream handling#17406
opencv-pushbot merged 1 commit intoopencv:3.4from
mshabunin:fix-msmf-audio-handling

Conversation

@mshabunin
Copy link
Copy Markdown
Contributor

@mshabunin mshabunin commented May 27, 2020 •
edited
Loading

resolves #17400

Skip audio streams when looking for best format match.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@mshabunin mshabunin mentioned this pull request May 27, 2020
Closed
@nakamura2000
Copy link
Copy Markdown

nakamura2000 commented May 27, 2020

I applied this patch and I confirmed this patch fixed issue #17406 with test case I reported.
I saved the result image and confirmed that image is correct frame.

alalek
alalek approved these changes May 27, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@opencv-pushbot opencv-pushbot merged commit 4b5fdc6 into opencv:3.4 May 27, 2020
@mshabunin mshabunin deleted the fix-msmf-audio-handling branch May 27, 2020 20:19
@alalek alalek mentioned this pull request May 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

bug category: videoio Hackathon https://opencv.org/opencv-hackathon-starts-next-week/ platform: win32

Projects

None yet

Milestone

3.4.11

Development

Successfully merging this pull request may close these issues.

VideoCapture fails to get frame if I use msmf and mp4 has audio stream.

4 participants

@mshabunin @nakamura2000 @alalek @opencv-pushbot