Apply normalization to 7p algorithm.#16612
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Feb 18, 2020
rabbull:master
Merged
Apply normalization to 7p algorithm.#16612opencv-pushbot merged 1 commit intoopencv:3.4from rabbull:master
opencv-pushbot merged 1 commit intoopencv:3.4from
rabbull:master
Conversation
Member
|
Thank you for contribution! As a "bugfix" this patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly). So, please:
Note: no needs to re-open PR, apply changes "inplace". |
Contributor
Author
|
@alalek |
Member
|
Merge commit ("rebase to 3.4") is not needed here (as you can see, this PR contains 1,141 commits now). Drop it: |
alalek
reviewed
Feb 18, 2020
modules/calib3d/src/fundam.cpp
Outdated
|
|
||
| Point2d m1c(0, 0), m2c(0, 0); | ||
| double t, scale1 = 0, scale2 = 0; | ||
| constexpr int count = 7; |
Member
There was a problem hiding this comment.
Please remove constexpr - use C++98 only => const
use const instead of constexpr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #10643
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Attempting to fix the bug issued in #10643, I just copied (modified a few lines) from the normalization part of 8p algorithm implemented by OpenCV. The original fundam tests are passed and no additional tests are privided.