Skip to content

MSMF: refactored format handling and property access#16527

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
mshabunin:fix-msmf-fmt-34
Feb 10, 2020
Merged

MSMF: refactored format handling and property access#16527
opencv-pushbot merged 1 commit intoopencv:3.4from
mshabunin:fix-msmf-fmt-34

Conversation

@mshabunin
Copy link
Copy Markdown
Contributor

@mshabunin mshabunin commented Feb 7, 2020

resolves #12822

  • removed unused functions and tables
  • refactored class MediaType, removed unused fields, renamed others, added several methods for convenience, added operator<< for debugging
  • extracted format enumeration and choosing logic to separate class FormatStorage
  • extracted device enumeration to class DeviceList
  • extracted methods to be used in property access methods
  • issue have been fixed by selecting native format first (the one returned by device) and requested format after that (format that we will use)
  • added early break to videoio frame reading tests in case of failure

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@mshabunin mshabunin force-pushed the fix-msmf-fmt-34 branch 2 times, most recently from 52e24f9 to 17b8a81 Compare February 7, 2020 13:52
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@opencv-pushbot opencv-pushbot merged commit 6c8f50d into opencv:3.4 Feb 10, 2020
@alalek alalek mentioned this pull request Feb 10, 2020
@asmorkalov asmorkalov added the Hackathon https://opencv.org/opencv-hackathon-starts-next-week/ label Feb 14, 2020
@mshabunin mshabunin deleted the fix-msmf-fmt-34 branch July 14, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: videoio Hackathon https://opencv.org/opencv-hackathon-starts-next-week/ platform: win32

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Video capture resolution stuck in Windows MSMF backend

4 participants