cvdef.h: Don't use C's limits.h under C++#16459
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Jan 30, 2020
Merged
Conversation
Member
|
Thank you for contribution! This patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly). So, please:
Note: no needs to re-open PR, apply changes "inplace". |
Contributor
Author
|
Will do, thanks! |
Just like with the other headers in the rest of the file. See e.g. https://stackoverflow.com/questions/36831465/what-difference-does-it-make-when-i-include-limits-or-limits-h-in-my-c-cod for the reasons, the most important one being that limits.h does not respect namespaces, which can make problems for downstream consumers of cvdef.h.
Contributor
Author
|
Rebase done. |
alalek
approved these changes
Jan 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest changes
<limits.h>-><limits>in C++ mode, just like with the other headers in the rest of the file.See e.g. StackOverflow for the reasons, the most important one being that limits.h does not respect namespaces, which can make problems for downstream consumers of
cvdef.h.