Skip to content

feat(android): add parameter for choose modules for android#16396

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
miguelps:android_modules
Jan 22, 2020
Merged

feat(android): add parameter for choose modules for android#16396
opencv-pushbot merged 1 commit intoopencv:3.4from
miguelps:android_modules

Conversation

@miguelps
Copy link
Copy Markdown

@miguelps miguelps commented Jan 20, 2020

This pullrequest changes

build_sdk.py, which compiles OpenCV-SDK for Android.

Added an option/parameter for build only selected modules (for Android), like a whitelist.
Care should be take to include modules which are required to others (this is not checked).

==============
call sample:

python2 ../platforms/android/build_sdk.py
--modules_list core,imgcodecs,improc
~/projects/opencv/build
~/projects/opencv

@miguelps miguelps requested a review from alalek January 20, 2020 20:31
@asmorkalov
Copy link
Copy Markdown
Contributor

@miguelps Thanks for the contribution, please restore empty lines in the script.

@hannesa2
Copy link
Copy Markdown
Contributor

I at least would love to see such call examples

python2 ../platforms/android/build_sdk.py
--modules_list core,imgcodecs,improc
~/projects/opencv/build
~/projects/opencv

in this file https://github.com/opencv/opencv/blob/master/platforms/android/README.android

@miguelps
Copy link
Copy Markdown
Author

Hi Alexander
Empty lines restored.
But
https://github.com/opencv/opencv/blob/master/platforms/android/README.android
refers to an HTML page (it is only a link).
How can I suggest updates to HTML page(s)?

@alalek
Copy link
Copy Markdown
Member

alalek commented Jan 22, 2020

README.android is not a good place right now. Also there is no easy process for contributing updates to HTML pages on opencv.org.

Please remove unused files (.sh) and squash commits into one (before rebasing, see below).


This patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

So, please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@asmorkalov asmorkalov added the pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch label Jan 22, 2020
@miguelps miguelps changed the base branch from master to 3.4 January 22, 2020 15:20
@miguelps
Copy link
Copy Markdown
Author

ok, done!

@opencv-pushbot opencv-pushbot merged commit 814a5ce into opencv:3.4 Jan 22, 2020
@alalek alalek mentioned this pull request Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants