dnn(onnx): handle unaligned access in ONNX importer#16377
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Jan 20, 2020
Merged
dnn(onnx): handle unaligned access in ONNX importer#16377opencv-pushbot merged 1 commit intoopencv:3.4from
opencv-pushbot merged 1 commit intoopencv:3.4from
Conversation
dkurt
reviewed
Jan 20, 2020
| memcpy(aligned_val.data(), val, sz); | ||
| val = (const char*)aligned_val.data(); | ||
| } | ||
| const int64_t* src = reinterpret_cast<const int64_t*>(val); |
Member
There was a problem hiding this comment.
Shall we do the same for floats data?
opencv/modules/dnn/src/onnx/onnx_importer.cpp
Lines 129 to 130 in 55d54b5
Member
Author
There was a problem hiding this comment.
Mat::copyTo() uses type-agnostic memcpy() internally.
.copyTo()is safe.convertTo()is not safe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #16373