Skip to content

Wrap custom OpenCV layers to try-catch#16354

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
dkurt:dnn_ie_custom_cpu_layers
Jan 15, 2020
Merged

Wrap custom OpenCV layers to try-catch#16354
opencv-pushbot merged 1 commit intoopencv:3.4from
dkurt:dnn_ie_custom_cpu_layers

Conversation

@dkurt
Copy link
Copy Markdown
Member

@dkurt dkurt commented Jan 15, 2020 •
edited
Loading

This pullrequest changes

ie.AddExtension(extension, "CPU");

is wrapped to try-catch so we need to do the same for

ie.AddExtension(std::make_shared<InfEngineExtension>(), "CPU");
force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2019r3.0:16.04
build_image:Custom Win=openvino-2019r3.0
build_image:Custom Mac=openvino-2019r3.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

@dkurt dkurt requested a review from mshabunin January 15, 2020 12:12
@dkurt dkurt force-pushed the dnn_ie_custom_cpu_layers branch from 487149b to 18513e3 Compare January 15, 2020 12:38
alalek
alalek reviewed Jan 15, 2020
View reviewed changes
@dkurt dkurt force-pushed the dnn_ie_custom_cpu_layers branch from 18513e3 to 7c741f5 Compare January 15, 2020 14:45
alalek
alalek approved these changes Jan 15, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

opencv-pushbot pushed a commit that referenced this pull request Jan 15, 2020
@alalek
Merge pull request #16354 from dkurt:dnn_ie_custom_cpu_layers
f6a8f78
@opencv-pushbot opencv-pushbot merged commit 7c741f5 into opencv:3.4 Jan 15, 2020
@alalek alalek mentioned this pull request Jan 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

@mshabunin mshabunin Awaiting requested review from mshabunin

Assignees

@alalek alalek

Labels

bug category: dnn

Projects

None yet

Milestone

3.4.10

Development

Successfully merging this pull request may close these issues.

3 participants

@dkurt @alalek @opencv-pushbot