Make stitching script more pythonic#16257
Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom Jan 16, 2020
Merged
Conversation
mshabunin
reviewed
Dec 30, 2019
samples/python/stitching_detailed.py
Outdated
| parser.add_argument( | ||
| '--timelapse', action='store', default=None, | ||
| help="Output warped images separately as frames of a time lapse movie, " | ||
| "with "fixed_" prepended to input file names.", |
Contributor
There was a problem hiding this comment.
Non-escaped quotes here.
Contributor
Author
There was a problem hiding this comment.
Thanks, force pushed some fixes.
285c540 to
ae65d1d
Compare
Member
|
/cc @LaurentBerger |
Contributor
|
@mshabunin @alalek Do you have any concerns about the patch? |
opencv-pushbot
pushed a commit
that referenced
this pull request
Jan 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest changes
Improve the overall readability and maintainability of the Python example stitching script.
Specifically:
if, this also allows easily showing all available options in the help output.