added tutorial for text skewness correction by themechanicalcoder · Pull Request #16170 · opencv/opencv

themechanicalcoder · 2019-12-16T06:11:36Z

This pull request changes

Given an image containing a rotated block of text at an unknown angle in an image, it corrects the text skew by

Detecting the block of text in the image .
Computing the angle of the rotated text
Rotating the image to correct for the skew.
Before

After

asmorkalov · 2019-12-23T08:30:25Z

This patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

So, please:

change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
rebase your commits from master onto 3.4 branch. For example:
git rebase -i --onto upstream/3.4 upstream/master
(check list of your commits, save and quit (Esc + "wq" + Enter)
where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

asmorkalov

@themechanicalcoder thanks for the example code. OpenCV repository already contains image with rotated text opencv/samples/data/imageTextR.png. Could you set it as default path to image. Ready to use example with example input makes things simpler.

samples/python/text_skewness_correction.py

asmorkalov · 2019-12-26T07:41:19Z

@themechanicalcoder I helped you with the PR rebase and pushed changes to your branch. Please remove or rename your local git branch and fetch tutorial_1 branch from Github to continue development or fix remarks.

asmorkalov · 2020-01-02T17:14:25Z

@themechanicalcoder Please adjust C++ code to general OpenCV coding guidelines: https://github.com/opencv/opencv/wiki/Coding_Style_Guide#code-layout
General notes:

Please separate function parameters with spaces in consistent way.
Use the same approach for code blocks -- move braces to new line. Opening and closing braces should have the same identation.

themechanicalcoder · 2020-01-03T14:10:57Z

@asmorkalov done

samples/cpp/text_skewness_correction.cpp

asmorkalov · 2020-01-10T06:05:12Z

@themechanicalcoder Please cover remaining comments and squeeze commits in the branch to merge it as single change.

samples/cpp/text_skewness_correction.cpp

samples/python/text_skewness_correction.py

asmorkalov · 2020-01-14T05:40:49Z

@themechanicalcoder Please fix formatting issues to unblock PR merge.

asmorkalov · 2020-01-20T07:32:18Z

@themechanicalcoder Friendly reminder. There are pending review notes in the PR.

themechanicalcoder · 2020-01-20T07:37:39Z

@themechanicalcoder Friendly reminder. There are pending review notes in the PR.

@asmorkalov which ones? I think I have applied all the suggestions that have come on this PR

asmorkalov · 2020-01-20T08:05:51Z

I see my comments with pending status above in the thread. Let me highlight them.

themechanicalcoder · 2020-01-23T02:46:36Z

@asmorkalov I went through all the comments and found that this one was the only one that I had missed

asmorkalov · 2020-01-23T05:26:22Z

@themechanicalcoder I squashed commits in your branch and fixed bug in C++ code.

asmorkalov · 2020-01-23T05:27:03Z

👍 @alalek please take a look and merge. Both Python and C++ versions has been tested with Ubuntu 18.04.

asmorkalov · 2019-12-27T10:14:25Z

samples/python/text_skewness_correction.py

+
+def main():
+    import sys
+    import argparse


It's better to move it on top to have all imports in one place.

asmorkalov · 2020-01-04T18:44:00Z

samples/cpp/text_skewness_correction.cpp

+    Mat thresh;
+    threshold(gray, thresh, 0, 255, THRESH_BINARY | THRESH_OTSU);
+
+    vector<Point2f>coords;


space is missing after type.

samples/cpp/text_skewness_correction.cpp

asmorkalov · 2020-01-10T06:02:31Z

samples/cpp/text_skewness_correction.cpp

+    Mat gray;
+    cvtColor(image, gray, COLOR_BGR2GRAY );
+
+


Extra line is not required here

samples/python/text_skewness_correction.py

asmorkalov · 2020-01-10T06:04:05Z

samples/python/text_skewness_correction.py

+    # otherwise, just take the inverse of the angle to make
+    # it positive
+    else:
+        angle = -angle


Empty lines inside and after if statement are not consistent, it confuses reader.

asmorkalov added category: samples pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch labels Dec 16, 2019

asmorkalov reviewed Dec 23, 2019

View reviewed changes

samples/python/text_skewness_correction.py Outdated Show resolved Hide resolved

themechanicalcoder changed the base branch from master to 3.4 December 23, 2019 09:31

themechanicalcoder force-pushed the tutorial_1 branch from 2b6b1d9 to da90b8a Compare December 23, 2019 13:49

themechanicalcoder changed the base branch from 3.4 to master December 23, 2019 14:29

themechanicalcoder changed the base branch from master to 3.4 December 23, 2019 14:29

themechanicalcoder changed the base branch from 3.4 to master December 23, 2019 15:02

themechanicalcoder changed the base branch from master to 3.4 December 23, 2019 15:09

asmorkalov force-pushed the tutorial_1 branch from da90b8a to d6647d6 Compare December 26, 2019 07:39

asmorkalov removed the pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch label Dec 26, 2019

themechanicalcoder requested a review from asmorkalov December 30, 2019 14:41

sturkmen72 reviewed Jan 4, 2020

View reviewed changes

samples/cpp/text_skewness_correction.cpp Outdated Show resolved Hide resolved

themechanicalcoder force-pushed the tutorial_1 branch 2 times, most recently from e0b7557 to cbd5847 Compare January 10, 2020 12:10

alalek reviewed Jan 10, 2020

View reviewed changes

samples/cpp/text_skewness_correction.cpp Show resolved Hide resolved

samples/cpp/text_skewness_correction.cpp Show resolved Hide resolved

samples/python/text_skewness_correction.py Outdated Show resolved Hide resolved

themechanicalcoder requested a review from alalek January 16, 2020 15:51

Added tutorial for text skewness correction in C++ and Python.

a6359e4

asmorkalov force-pushed the tutorial_1 branch from 7563acf to a6359e4 Compare January 23, 2020 05:26

asmorkalov approved these changes Jan 23, 2020

View reviewed changes

alalek assigned asmorkalov Jan 24, 2020

opencv-pushbot pushed a commit that referenced this pull request Jan 24, 2020

Merge pull request #16170 from themechanicalcoder:tutorial_1

043b9fb

opencv-pushbot merged commit a6359e4 into opencv:3.4 Jan 24, 2020

alalek mentioned this pull request Jan 28, 2020

Merge 3.4 #16450

Merged

Uh oh!

Conversation

themechanicalcoder commented Dec 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This pull request changes

Uh oh!

asmorkalov commented Dec 23, 2019

Uh oh!

asmorkalov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

asmorkalov commented Dec 26, 2019

Uh oh!

asmorkalov commented Jan 2, 2020

Uh oh!

themechanicalcoder commented Jan 3, 2020

Uh oh!

Uh oh!

asmorkalov commented Jan 10, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asmorkalov commented Jan 14, 2020

Uh oh!

asmorkalov commented Jan 20, 2020

Uh oh!

themechanicalcoder commented Jan 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

asmorkalov commented Jan 20, 2020

Uh oh!

themechanicalcoder commented Jan 23, 2020

Uh oh!

asmorkalov commented Jan 23, 2020

Uh oh!

asmorkalov commented Jan 23, 2020

Uh oh!

asmorkalov Dec 27, 2019

Choose a reason for hiding this comment

Uh oh!

asmorkalov Jan 20, 2020

Choose a reason for hiding this comment

Uh oh!

asmorkalov Jan 4, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

asmorkalov Jan 10, 2020

Choose a reason for hiding this comment

Uh oh!

asmorkalov Jan 20, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

asmorkalov Jan 10, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

themechanicalcoder commented Dec 16, 2019 •

edited

Loading

themechanicalcoder commented Jan 20, 2020 •

edited

Loading