Skip to content

G-API: Fix various issues for 4.2 release#16081

Merged
alalek merged 6 commits intoopencv:masterfrom
dmatveev:dm/ocv42_gapi_bugfixes
Dec 10, 2019
Merged

G-API: Fix various issues for 4.2 release#16081
alalek merged 6 commits intoopencv:masterfrom
dmatveev:dm/ocv42_gapi_bugfixes

Conversation

@dmatveev
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev commented Dec 6, 2019 •
edited by alalek
Loading 

buildworker:Custom=linux-1
build_image:Custom=fedora:31

@dmatveev
G-API: Fix issues reported by Coverity
902a759 
- Fixed: passing values by value instead of passing by reference
@dmatveev
G-API: Fix redundant std::move()'s in return statements
6e2d70d 
Fixes opencv#15903
@dmatveev dmatveev added this to the 4.2.0 milestone Dec 6, 2019
@dmatveev
Copy link
Copy Markdown
Contributor Author

dmatveev commented Dec 6, 2019

@AsyaPronina @rgarnov please review the latest fixes.

@alalek can you please trigger the relevant builds to test the fixed issues?

rgarnov
rgarnov approved these changes Dec 9, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@rgarnov rgarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pointed some misprints

@dmatveev
Copy link
Copy Markdown
Contributor Author

dmatveev commented Dec 10, 2019

@rgarnov all fixed, thanks!

@dmatveev
Copy link
Copy Markdown
Contributor Author

dmatveev commented Dec 10, 2019

@alalek can this be merged? Anything else required?

@alalek alalek merged commit 9a18330 into opencv:master Dec 10, 2019
@dmatveev
Copy link
Copy Markdown
Contributor Author

dmatveev commented Dec 10, 2019

Thanks!

@mshabunin
Copy link
Copy Markdown
Contributor

mshabunin commented Dec 11, 2019

Looks like this patch causes build errors with GCC 4.8.5 (CentOS 7):

../opencv/modules/gapi/src/backends/fluid/gfluidbuffer.cpp: In function 'std::unique_ptr<cv::gapi::fluid::BufferStorage> cv::gapi::fluid::{anonymous}::createStorage(int, int, int, int, cv::gapi::fluid::BorderOpt)':
../opencv/modules/gapi/src/backends/fluid/gfluidbuffer.cpp:350:16: error: cannot bind 'std::unique_ptr<cv::gapi::fluid::BufferStorageWithBorder>' lvalue to 'std::unique_ptr<cv::gapi::fluid::BufferStorageWithBorder>&&'
         return storage;
                ^
In file included from /usr/include/c++/4.8.2/memory:81:0,
                 from ../opencv/modules/core/include/opencv2/core/cvstd_wrapper.hpp:11,
                 from ../opencv/modules/core/include/opencv2/core/cvstd.hpp:81,
                 from ../opencv/modules/core/include/opencv2/core/base.hpp:58,
                 from ../opencv/modules/core/include/opencv2/core.hpp:54,
                 from ../opencv/modules/gapi/src/precomp.hpp:12,
                 from ../opencv/modules/gapi/src/backends/fluid/gfluidbuffer.cpp:8:
/usr/include/c++/4.8.2/bits/unique_ptr.h:169:2: error:   initializing argument 1 of 'std::unique_ptr<_Tp, _Dp>::unique_ptr(std::unique_ptr<_Up, _Ep>&&) [with _Up = cv::gapi::fluid::BufferStorageWithBorder; _Ep = std::default_delete<cv::gapi::fluid::BufferStorageWithBorder>; <template-parameter-2-3> = void; _Tp = cv::gapi::fluid::BufferStorage; _Dp = std::default_delete<cv::gapi::fluid::BufferStorage>]'
  unique_ptr(unique_ptr<_Up, _Ep>&& __u) noexcept
  ^

@alalek alalek mentioned this pull request Dec 11, 2019
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@dmatveev
Merge pull request opencv#16081 from dmatveev:dm/ocv42_gapi_bugfixes
c4bc8ec 
G-API: Fix various issues for 4.2 release

* G-API: Fix issues reported by Coverity

- Fixed: passing values by value instead of passing by reference

* G-API: Fix redundant std::move()'s in return statements

Fixes opencv#15903

* G-API: Added a smarter handling of Stop messages in the pipeline

- This should fix the "expected 100, got 99 frames" problem
- Fixes opencv#15882

* G-API: Pass enum instead of GKernelPackage in Streaming test parameters

- Likely fixes opencv#15836

* G-API: Address review issues in new bugfix comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AsyaPronina AsyaPronina AsyaPronina approved these changes

@rgarnov rgarnov rgarnov approved these changes

Assignees

@rgarnov rgarnov

Labels

category: g-api / gapi

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

G-API: build warnings with GCC 9 G-API: coverage failure G-API: valgrind issues (2019-11-02)

5 participants

@dmatveev @mshabunin @AsyaPronina @rgarnov @alalek