Skip to content

Fixes typo in calib3d.hpp#16006

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
sajarin:typo
Nov 30, 2019
Merged

Fixes typo in calib3d.hpp#16006
opencv-pushbot merged 1 commit intoopencv:3.4from
sajarin:typo

Conversation

@sajarin
Copy link
Copy Markdown
Contributor

@sajarin sajarin commented Nov 27, 2019

resolves #13523

Fixes a typo in the calib3d.hpp file. ( (Scheimpfug condition) to (Scheimpflug principle)

@alalek
Copy link
Copy Markdown
Member

alalek commented Nov 27, 2019

Thank you for contribution!

This patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

So, please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

P.S. "Merge" commit should be excluded from the patchset.

@asmorkalov asmorkalov added the pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch label Nov 29, 2019
@opencv-pushbot opencv-pushbot merged commit 101a147 into opencv:3.4 Nov 30, 2019
@sajarin sajarin deleted the typo branch November 30, 2019 21:17
@sajarin
Copy link
Copy Markdown
Contributor Author

sajarin commented Nov 30, 2019

@alalek Thank you for rebasing and apologies for not doing it sooner myself. In future PRs, I will try to base my changes correctly.

@alalek alalek mentioned this pull request Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants