Skip to content

G-API: Tutorial: Face beautification algorithm implementation #15942

Merged
alalek merged 2 commits intoopencv:masterfrom
OrestChura:fb_tutorial
Dec 17, 2019
Merged

G-API: Tutorial: Face beautification algorithm implementation #15942
alalek merged 2 commits intoopencv:masterfrom
OrestChura:fb_tutorial

Conversation

@OrestChura
Copy link
Copy Markdown
Contributor

@OrestChura OrestChura commented Nov 18, 2019 •
edited
Loading

This pullrequest changes

  • Introducing a tutorial, which goals are:
  1. Description with examples of G-API features:
    • Inference-API usage
    • Streaming-API usage
  2. Some face beautification algorithm implementation interesting points discussion
  • The description of the tutorial was added on G-API tutorial main page
    ("tutorials/gapi/table_of_content_gapi.markdown")
force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2019r2.0:16.04
build_image:Custom Win=openvino-2019r2.0
build_image:Custom Mac=openvino-2019r2.0

test_modules:Custom=gapi
test_modules:Custom Win=gapi
test_modules:Custom Mac=gapi

buildworker:Custom=linux-1
test_opencl:Custom=ON
test_bigdata:Custom=1
test_filter:Custom=*

build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f
build_gapi_standalone:Custom Win=ade-0.1.1f

@OrestChura
Copy link
Copy Markdown
Contributor Author

OrestChura commented Nov 28, 2019 •
edited
Loading

The introduction, the "New G-API features description" and "Algorithm" sections basic version has been completed; please review it @dmatveev @AsyaPronina @TolyaTalamanov @rgarnov
optional: @smirnov-alexey @anton-potapov @aDanPin @dbudniko @akhakim @dkurt @l-bat
Link: https://pullrequest.opencv.org/buildbot/export/pr/15942/docs/d4/d48/tutorial_gapi_face_beautification.html

OrestChura
OrestChura commented Nov 28, 2019
View reviewed changes
smirnov-alexey
smirnov-alexey reviewed Nov 29, 2019
View reviewed changes
smirnov-alexey
smirnov-alexey reviewed Nov 29, 2019
View reviewed changes
smirnov-alexey
smirnov-alexey reviewed Nov 29, 2019
View reviewed changes
@dmatveev
Copy link
Copy Markdown
Contributor

dmatveev commented Dec 12, 2019

@dmatveev, one more iteration. Not perfect but a bit closer.

@dkurt awesome, thanks!

rgarnov
rgarnov reviewed Dec 13, 2019
View reviewed changes
samples/cpp/tutorial_code/gapi/face_beautification/face_beautification.cpp
cv::GArray<Landmarks> garElems; // |
cv::GArray<Contour> garJaws; // |output arrays
//! [net_usg_ld]
cv::GArray<cv::GMat> landmOut = cv::gapi::infer<custom::LandmDetector>(garRects, gimgIn);
Copy link
Copy Markdown
Contributor

@rgarnov rgarnov Dec 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to add more blank lines to separate remaining parts of the pipeline. BTW, why garElems and garJaws declared before landmOut?

Copy link
Copy Markdown
Contributor Author

@OrestChura OrestChura Dec 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes, they can be declared later, thank you! (blank lines added)

smirnov-alexey
smirnov-alexey reviewed Dec 13, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@smirnov-alexey smirnov-alexey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest is good for me

@OrestChura
Introduce a tutorial on face beautification algorithm
fb240d5 
- small typo issue in render_ocv.cpp
@OrestChura
Copy link
Copy Markdown
Contributor Author

OrestChura commented Dec 16, 2019 •
edited
Loading

@rgarnov @smirnov-alexey, (pre-)final review can be started, sorry for the unconvenience

@OrestChura
Copy link
Copy Markdown
Contributor Author

OrestChura commented Dec 16, 2019

@TolyaTalamanov

rgarnov
rgarnov approved these changes Dec 16, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@rgarnov rgarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

dmatveev
dmatveev approved these changes Dec 17, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for this hard work!

@alalek alalek merged commit 287874a into opencv:master Dec 17, 2019
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@OrestChura
Merge pull request opencv#15942 from OrestChura:fb_tutorial
a1afce6 
G-API: Tutorial: Face beautification algorithm implementation

* Introduce a tutorial on face beautification algorithm

- small typo issue in render_ocv.cpp

* Addressing comments rgarnov smirnov-alexey
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkurt dkurt dkurt left review comments

@smirnov-alexey smirnov-alexey smirnov-alexey left review comments

@dmatveev dmatveev dmatveev approved these changes

@rgarnov rgarnov rgarnov approved these changes

+1 more reviewer

@hannesa2 hannesa2 hannesa2 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dmatveev dmatveev

Labels

category: g-api / gapi

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

7 participants

@OrestChura @smirnov-alexey @dmatveev @dkurt @alalek @hannesa2 @rgarnov