Update seamless_cloning.cpp#15929
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Jan 19, 2020
Merged
Conversation
alalek
reviewed
Nov 18, 2019
| if (p.y < 0) | ||
| p.y = dest.rows / 2; | ||
|
|
||
| Rect roi_d(p.x - roi_s.width / 2, p.y - roi_s.height / 2, roi_s.width, roi_s.height); |
Member
There was a problem hiding this comment.
Need to ensure somehow that Rect args are still valid.
Contributor
There was a problem hiding this comment.
How can I pull sturkmen72's code in order to work on this?
Contributor
|
@alalek Do you have any remarks to the patch or I can squash and merge it? |
Member
|
@asmorkalov Please check issue's comments: #15928 |
Contributor
Author
|
i reverted commits related with #15928 |
alalek
approved these changes
Jan 19, 2020
| if (mask.channels() == 3) | ||
| cvtColor(mask, gray, COLOR_BGR2GRAY); | ||
| if (mask.channels() > 1) | ||
| cvtColor(mask, gray, COLOR_BGRA2GRAY); |
Member
There was a problem hiding this comment.
COLOR_BGR2GRAY
Should work with both BGR/BGRA input too.
opencv-pushbot
pushed a commit
that referenced
this pull request
Jan 19, 2020
This was referenced Jan 20, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest changes
resolves #15927