Skip to content

Refactor opencl_info#15883

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
cbachhuber:refactor-opencl-information
Nov 12, 2019
Merged

Refactor opencl_info#15883
opencv-pushbot merged 1 commit intoopencv:3.4from
cbachhuber:refactor-opencl-information

Conversation

@cbachhuber
Copy link
Copy Markdown
Contributor

@cbachhuber cbachhuber commented Nov 10, 2019 •
edited by alalek
Loading

This pullrequest refactors parts of opencl information dumping:

  • Remove code duplication
  • Clarify functionality of ternary operator
  • Use cv's String instead of char * for strings
  • Remove unused code
force_builders=Custom,Linux AVX2,Linux OpenCL
build_image:Custom=ubuntu:18.04
buildworker:Custom=linux-5
test_opencl:Custom=ON

build_image:Linux AVX2=ubuntu:18.04
buildworker:Linux AVX2=linux-3
test_opencl:Linux AVX2=ON

@cbachhuber cbachhuber mentioned this pull request Nov 10, 2019
Merged
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Nov 11, 2019

@i-murzov Please take a look.

GArik
GArik suggested changes Nov 11, 2019
View reviewed changes
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Nov 12, 2019 •
edited by alalek
Loading

LGTM 👍 @cbachhuber please squash commits.

GArik
GArik reviewed Nov 12, 2019
View reviewed changes
@cbachhuber
Refactor for clarity and avoiding code duplication
c638f08 
Implement GArik's comments

Remove unnecessary c_str()

Fix brace position
@cbachhuber cbachhuber force-pushed the refactor-opencl-information branch from b9f62b5 to c638f08 Compare November 12, 2019 18:25
@cbachhuber
Copy link
Copy Markdown
Contributor Author

cbachhuber commented Nov 12, 2019

Thank you for the reviews, squashed commits

opencv-pushbot pushed a commit that referenced this pull request Nov 12, 2019
@alalek
Merge pull request #15883 from cbachhuber:refactor-opencl-information
a67248f
@opencv-pushbot opencv-pushbot merged commit c638f08 into opencv:3.4 Nov 12, 2019
@alalek alalek mentioned this pull request Nov 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek left review comments

+1 more reviewer

@GArik GArik GArik requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@asmorkalov asmorkalov

Labels

category: core category: ocl

Projects

None yet

Milestone

3.4.9

Development

Successfully merging this pull request may close these issues.

5 participants

@cbachhuber @asmorkalov @GArik @alalek @opencv-pushbot