Skip to content

Fix YAML parse#15842

Merged
alalek merged 3 commits intoopencv:masterfrom
TH3CHARLie:yaml-fix
Nov 4, 2019
Merged

Fix YAML parse#15842
alalek merged 3 commits intoopencv:masterfrom
TH3CHARLie:yaml-fix

Conversation

@TH3CHARLie
Copy link
Copy Markdown
Contributor

@TH3CHARLie TH3CHARLie commented Nov 4, 2019

resolves #14130

This pullrequest changes

This pullrequest changes core/persistence_yml.cpp to fix incorrect YAML parse behavior. Current 4.x fails to read multiple documents from single file.

@alalek
Copy link
Copy Markdown
Member

alalek commented Nov 4, 2019

Could you add some simple test here to avoid regressions in the future? (adapt issue's reproducer)

@TH3CHARLie
Copy link
Copy Markdown
Contributor Author

TH3CHARLie commented Nov 4, 2019

@alalek Sure, I'm on it @alalek The build has passed and is this newly added test enough?

Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thank you for contribution 👍

@alalek alalek merged commit a165f55 into opencv:master Nov 4, 2019
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
* fix yaml parse

* add test for YAML parse multiple documents

* remove trailing whitespace in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using FileStorage::APPEND

2 participants