stitching_detailed: use correct match_conf default#15756
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Oct 22, 2019
Merged
stitching_detailed: use correct match_conf default#15756opencv-pushbot merged 1 commit intoopencv:3.4from
opencv-pushbot merged 1 commit intoopencv:3.4from
Conversation
Member
|
Thank you for contribution! As a "bugfix" this patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly). So, please:
Note: no needs to re-open PR, apply changes "inplace". |
520e8cf to
d9230dc
Compare
Contributor
Author
|
Ugh, sorry for going to the wrong branch -- I should have read the contribution guide more closely :(. I've rebased and resolved conflicts. PTAL. |
The usage function states that the default for match_conf is 0.65 if the default SURF feature finder is used, and 0.3 for orbs. Indeed, if --feature orbs is used, match_conf is set to 0.3f. This is a NOP, because the real default is also set to 0.3f. Change it to 0.65f when SURF is in play.
d9230dc to
6e9eca2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest changes
The usage function states that the default for match_conf is
0.65 if the default SURF feature finder is used, and 0.3 for
orbs. Indeed, if --feature orbs is used, match_conf is set
to 0.3f. This is a NOP, because the real default is also set
to 0.3f. Change it to 0.65f when SURF is in play.