Skip to content

Fixed clang -Wnewline-eof warning by adding newline to end of file#15666

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
seanm:Wnewline
Oct 9, 2019
Merged

Fixed clang -Wnewline-eof warning by adding newline to end of file#15666
opencv-pushbot merged 1 commit intoopencv:3.4from
seanm:Wnewline

Conversation

@seanm
Copy link
Copy Markdown
Contributor

@seanm seanm commented Oct 8, 2019

No description provided.

@seanm
Copy link
Copy Markdown
Contributor Author

seanm commented Oct 8, 2019

@alalek

@alalek
Copy link
Copy Markdown
Member

alalek commented Oct 8, 2019

This patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

So, please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@asmorkalov asmorkalov self-assigned this Oct 9, 2019
@asmorkalov asmorkalov self-requested a review October 9, 2019 07:13
@asmorkalov asmorkalov changed the base branch from master to 3.4 October 9, 2019 07:13
@asmorkalov
Copy link
Copy Markdown
Contributor

👍

opencv-pushbot pushed a commit that referenced this pull request Oct 9, 2019
@opencv-pushbot opencv-pushbot merged commit 24effe8 into opencv:3.4 Oct 9, 2019
@alalek alalek mentioned this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants