upgrade the file to use the correct package name and include py3/gtk3…#15644
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Oct 5, 2019
Merged
upgrade the file to use the correct package name and include py3/gtk3…#15644opencv-pushbot merged 1 commit intoopencv:3.4from
opencv-pushbot merged 1 commit intoopencv:3.4from
Conversation
alalek
reviewed
Oct 5, 2019
Member
alalek
left a comment
There was a problem hiding this comment.
Thank for contribution! Especially for looking on documentation!
Please,
- take a look on comments below
- fix whitespace errors (check build status)
- additionally it make sense to update line 8 about Ubuntu versions (=> 16.04/18.04, both 64-bit)
Also this patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly).
So, please:
- change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
- rebase your commits from master onto 3.4 branch. For example:
git rebase -i --onto upstream/3.4 upstream/master
(check list of your commits, save and quit (Esc + "wq" + Enter)
whereupstreamis configured by following this GitHub guide and fetched (git fetch upstream). - push rebased commits into source branch of your fork (with
--forceoption)
Note: no needs to re-open PR, apply changes "inplace".
| to support python3: | ||
|
|
||
| ``` | ||
| sudo apt-get install python3-dev python3-numpy |
Member
There was a problem hiding this comment.
BTW, numpy can be installed via virtualenv too (if no access to sudo, but other tools like gcc/cmake/python are here)
| ``` | ||
| sudo apt-get install libpng-devel | ||
| sudo apt-get install libjpeg-turbo-devel | ||
| sudo apt-get install jasper-devel |
Member
There was a problem hiding this comment.
BTW, Jasper is available in Ubuntu 16.04, but it has been dropped from Ubuntu 18.04.
| sudo apt-get install libtiff-devel | ||
| sudo apt-get install libwebp-devel | ||
| sudo apt-get install libpng-dev | ||
| sudo apt-get install libjpeg-turbo8-dev |
Member
There was a problem hiding this comment.
libjpeg-dev is enough (aliased to underlying package)
b22a302 to
b1485d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest changes
Update the Ubuntu tutorial using the correct package name and add the package to support python3 and gtk3 instead of python2 and gtk2.
this pull request was developed during the