Skip to content

Added Rodrigues to the JS embindgen.py and a unittest in test_calib3d…#15595

Merged
alalek merged 2 commits intoopencv:3.4from
frastlin:rodrigues
Sep 27, 2019
Merged

Added Rodrigues to the JS embindgen.py and a unittest in test_calib3d…#15595
alalek merged 2 commits intoopencv:3.4from
frastlin:rodrigues

Conversation

@frastlin
Copy link
Copy Markdown
Contributor

@frastlin frastlin commented Sep 25, 2019 •
edited by alalek
Loading

I did something wrong and PR #15585 closed. This PR is on 3.4 and has the changes.

Resolves #15584

This pullrequest changes

Adds the Rodrigues function to the Calib3D module and adds a unittest in the js/tests folder.

force_builders=Custom
buildworker:Custom=linux-1,linux-2,linux-4
docker_image:Docs=docs-js
docker_image:Custom=javascript

alalek
alalek reviewed Sep 26, 2019
View reviewed changes
modules/js/src/embindgen.py Outdated
return wl

white_list = makeWhiteList([core, imgproc, objdetect, video, dnn, features2d, calib3d])
white_list = makeWhiteList([core, imgproc, objdetect, video, dnn, features2d, photo, aruco, calib3d])
Copy link
Copy Markdown
Member

@alalek alalek Sep 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unrelated changes (they are from the master branch only)

@frastlin
Copy link
Copy Markdown
Contributor Author

frastlin commented Sep 26, 2019

OK, I fixed it, and pushed to my PR branch on my fork, will it update here like it says, or do I need to do anything else?

alalek
alalek approved these changes Sep 27, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@alalek alalek merged commit 25dee83 into opencv:3.4 Sep 27, 2019
@alalek alalek mentioned this pull request Oct 2, 2019
Merged
@frastlin frastlin mentioned this pull request Oct 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: calib3d category: javascript (js) feature

Projects

None yet

Milestone

3.4.8

Development

Successfully merging this pull request may close these issues.

2 participants

@frastlin @alalek