Skip to content

Added Rodrigues to the JS embindgen.py and a unittest in test_calib3d.js#15585

Closed
frastlin wants to merge 0 commit intoopencv:masterfrom
frastlin:rodrigues
Closed

Added Rodrigues to the JS embindgen.py and a unittest in test_calib3d.js#15585
frastlin wants to merge 0 commit intoopencv:masterfrom
frastlin:rodrigues

Conversation

@frastlin
Copy link
Copy Markdown
Contributor

Resolves #15584

This pullrequest changes

Adds the Rodrigues function to the Calib3D module and adds a unittest in the js/tests folder.

@alalek
Copy link
Copy Markdown
Member

alalek commented Sep 25, 2019

This patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

So, please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build Rodrigues in Javascript

2 participants