Merged
Conversation
ISA 2.07 (aka POWER8) effectively extended the expanding multiply operation to word types. The altivec intrinsics prior to gcc 8 did not get the update. Workaround this deficiency similar to other fixes. This was exposed by commit 33fb253 which leverages the int -> dword expanding multiply. This fixes Issue opencv#15506
Contributor
Author
|
I want to wait for all the PPC builders to verify this. I only had GCC 7 readily available to reproduce and test on. |
alalek
approved these changes
Sep 13, 2019
Member
alalek
left a comment
There was a problem hiding this comment.
@pmur Thank you!
@seiko2plus I will merge this hotfix to fix builds. Please continue to work on #15510 approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add redirections for for vec_mul{e,o} prior to GCC8 to support older compilers.
resolves #15506