dshow: Add ability to save directshow graph#15467
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Oct 2, 2019
Merged
Conversation
aeeec9f to
f88d035
Compare
alalek
reviewed
Sep 6, 2019
Member
alalek
left a comment
There was a problem hiding this comment.
Thank you for contribution!
This patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly).
So, please:
- change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
- rebase your commits from master onto 3.4 branch. For example:
git rebase -i --onto upstream/3.4 upstream/master
(check list of your commits, save and quit (Esc + "wq" + Enter)
whereupstreamis configured by following this GitHub guide and fetched (git fetch upstream). - push rebased commits into source branch of your fork (with
--forceoption)
Note: no needs to re-open PR, apply changes "inplace".
f88d035 to
aeb5c5d
Compare
Contributor
Author
|
Rebased to 3.4 |
mshabunin
requested changes
Sep 25, 2019
Contributor
mshabunin
left a comment
There was a problem hiding this comment.
Please change the code according to the comments.
aeb5c5d to
8b483a9
Compare
mshabunin
approved these changes
Oct 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest changes
Adds ability to save the directshow graph by setting an environment variable providing a filename.