WIP: G-API: Internal IE flag check in public headers issue#15419
WIP: G-API: Internal IE flag check in public headers issue#15419alalek merged 2 commits intoopencv:masterfrom
Conversation
…ext_hdrs; + because of that a few #includes are required in the headers - HAVE_INF_ENGINE flag check in headers "infer/ie.hpp" and "infer/ie/util.hpp" is deleted
|
@AsyaPronina @dmatveev @alalek please review |
3rdparty types are not allowed in OpenCV regular public API. |
…ests; it's been moved to the scr directory to the place next to the implementation file "ie/giebackend.cpp" - the path to this header in files "ie/giebackend.cpp" and "test/infer/gapi_infer_ie_test.cpp" is updated - As it's private header now and explicitly depends on IE, the "HAVE_INF_ENGINE" flag check is returned
I have added changes you mentioned to make the header private, but mb it's not the right decision as the features could be helpful for a user. |
| @@ -27,5 +30,6 @@ GAPI_EXPORTS InferenceEngine::Blob::Ptr to_ie(cv::Mat &blob); | |||
|
|
|||
There was a problem hiding this comment.
Since this file is internal now, please put a note here why these functions are EXPORTed (to make them accessible by the test suite)
…_flag_issue * - headers in "infer/" and "infer/ie/" folders are included into gapi_ext_hdrs; + because of that a few #includes are required in the headers - HAVE_INF_ENGINE flag check in headers "infer/ie.hpp" and "infer/ie/util.hpp" is deleted * - the "ie/util.hpp" header is a private header now as it's used for tests; it's been moved to the scr directory to the place next to the implementation file "ie/giebackend.cpp" - the path to this header in files "ie/giebackend.cpp" and "test/infer/gapi_infer_ie_test.cpp" is updated - As it's private header now and explicitly depends on IE, the "HAVE_INF_ENGINE" flag check is returned
This pullrequest changes
OpenCV public API should not have features-based conditional compilation in general (because these internal flags are not available in user apps). Instead of using such condoitions, user should add checks into their app.
Also the headers for G-API inference should be put into gapi_ext_hdrs CMake varaible