Skip to content

Use commonly supported instruction mnemonic.#15414

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
kuzi117:instr
Aug 30, 2019
Merged

Use commonly supported instruction mnemonic.#15414
opencv-pushbot merged 1 commit intoopencv:3.4from
kuzi117:instr

Conversation

@kuzi117
Copy link
Copy Markdown
Contributor

@kuzi117 kuzi117 commented Aug 29, 2019 •
edited by alalek
Loading

resolves #15413

This pullrequest changes

This alters inline assembly to use an instruction mnemonic commonly supported by both gcc and clang. This does not alter functionality, only enables the file to be compiled. See explanation in #15413 for references to the ISA manual.

force_builders=Custom
buildworker:Custom=linux-1,linux-2,linux-4
build_image:Custom=powerpc64le

Extra PowerPC CI: https://ocv-power.imavr.com/#/opencv_pullrequests

@alalek
Copy link
Copy Markdown
Member

alalek commented Aug 29, 2019

Thank you for contribution!

Please re-target patch onto 3.4 branch (see some instructions in your previous PR).

@alalek
Copy link
Copy Markdown
Member

alalek commented Aug 29, 2019

@pmur Could you take a look on this patch?

@kuzi117 kuzi117 changed the base branch from master to 3.4 August 29, 2019 16:01
@kuzi117
Copy link
Copy Markdown
Contributor Author

kuzi117 commented Aug 29, 2019

@alalek Here as well. Let me know if either patch needs anything else.

@kuzi117
Copy link
Copy Markdown
Contributor Author

kuzi117 commented Aug 29, 2019

Test failures resulting from missing data files? I don't think this is related to me..?

@alalek
Copy link
Copy Markdown
Member

alalek commented Aug 29, 2019

Some builds are started against master branch, what is not correct (it is due lack of infra support and due target branch was switched after force-pushed commits).
I restarted related builds.

alalek
alalek approved these changes Aug 30, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

opencv-pushbot pushed a commit that referenced this pull request Aug 30, 2019
@alalek
Merge pull request #15414 from kuzi117:instr
f224d74
@opencv-pushbot opencv-pushbot merged commit 9bf8b49 into opencv:3.4 Aug 30, 2019
@alalek alalek mentioned this pull request Aug 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: core optimization platform: ppc (PowerPC)

Projects

None yet

Milestone

3.4.8

Development

Successfully merging this pull request may close these issues.

3 participants

@kuzi117 @alalek @opencv-pushbot