Added performance test for StereoBM algorithm#15399
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Sep 17, 2019
Merged
Added performance test for StereoBM algorithm#15399opencv-pushbot merged 1 commit intoopencv:3.4from
opencv-pushbot merged 1 commit intoopencv:3.4from
Conversation
b2efc17 to
6908900
Compare
alalek
approved these changes
Sep 5, 2019
|
|
||
| PERF_TEST_P(TestStereoCorrespBM, BM, Combine(Values(Size(1280, 720), Size(640, 480)), Values(256, 128))) | ||
| { | ||
| RNG rng(0); |
Member
There was a problem hiding this comment.
This is not needed in general:
https://github.com/opencv/opencv/blob/4.1.1/modules/ts/src/ts.cpp#L758-L763
Contributor
Author
There was a problem hiding this comment.
Default seed is non zero, so this change will affect sanity result for some test cases. I could remove it for BM test only and regenerate new sanity data, but IMO it would be better to retain similar tests uniform. The other option(the one I actually prefer) is to move zero RNG initialization to the MakeArtificialExample function that produce input to make things more consistent. The third option is to remove RNG initialization completely and regenerate both BM and SGBM sanity data.
5f44e68 to
d1041e6
Compare
d1041e6 to
bf8b5ff
Compare
opencv-pushbot
pushed a commit
that referenced
this pull request
Sep 17, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge with extra: opencv/opencv_extra#670
Added performance test for StereoBM algorithm