Skip to content

Fixed Typo Closes #15148#15329

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
craterkamath:fixTypoCamshift
Aug 19, 2019
Merged

Fixed Typo Closes #15148#15329
opencv-pushbot merged 1 commit intoopencv:3.4from
craterkamath:fixTypoCamshift

Conversation

@craterkamath
Copy link
Copy Markdown
Contributor

Fix #15148

Replaced outdated link with the working link.

@alalek
Copy link
Copy Markdown
Member

alalek commented Aug 19, 2019

Please avoid re-opening PRs. Use force push into existed branch instead.

@alalek
Copy link
Copy Markdown
Member

alalek commented Aug 19, 2019

This patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

So, please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@craterkamath craterkamath changed the base branch from master to 3.4 August 19, 2019 17:20
@craterkamath
Copy link
Copy Markdown
Contributor Author

I've followed the instructions, I think the patch is ready for merging. Do let me know if I can do anything more.

Thanks for the help @alalek

Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@opencv-pushbot opencv-pushbot merged commit 04f720d into opencv:3.4 Aug 19, 2019
@alalek alalek mentioned this pull request Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants