Skip to content

G-API: Support GArray as an input type in fluid#15312

Merged
alalek merged 5 commits intoopencv:masterfrom
smirnov-alexey:gapi_fluid_garray
Sep 2, 2019
Merged

G-API: Support GArray as an input type in fluid#15312
alalek merged 5 commits intoopencv:masterfrom
smirnov-alexey:gapi_fluid_garray

Conversation

@smirnov-alexey
Copy link
Copy Markdown
Contributor

This pullrequest adds support for GArray as an input type in fluid

@smirnov-alexey
Copy link
Copy Markdown
Contributor Author

smirnov-alexey commented Aug 15, 2019

@rgarnov , @andrey-golubev , @dmatveev , @TolyaTalamanov , please, review.

Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you add a compile-time check forbidding writing Fluid kernels with only input GArray argument and having no input GMat arguments?

Add assert that input GArgs in fluid contain at least one GMat
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@alalek alalek merged commit 8a7e746 into opencv:master Sep 2, 2019
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
* Support GArray as input in fluid kernels

* Create tests on GArray input in fluid

* Some fixes to fully support GArray

* Refactor code and change the kernel according to review

* Add histogram calculation as a G-API kernel

Add assert that input GArgs in fluid contain at least one GMat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants