Merged
Conversation
Member
|
Details:
|
Author
It is only one common situation. Not all images have TIFF header followed by the 0th IFD, such as the photo given above. Its offset of 0th IFD is 58 instead of fixed value 8. And the photo's orientation is 6, but original version can't get the value. |
alalek
approved these changes
Aug 5, 2019
Member
alalek
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest changes
ExifReader::getNumDirEntry use the fixed offset value, which may parse error number of DirEntry in some cases.
Following is structure of TIFF header. We should get the offset through "Offset to first IFD" item.