Fix build for UWP#15207
Merged
alalek merged 2 commits intoopencv:masterfrom Aug 3, 2019
vicroms:fix-uwp-build
Merged
Conversation
alalek
reviewed
Aug 2, 2019
Member
alalek
left a comment
There was a problem hiding this comment.
Thank you for contribution!
Please take a look on comment below.
| if(WINRT AND BUILD_TESTS) | ||
| # removing APPCONTAINER from tests to run from console | ||
| # look for detailed description inside of ocv_create_module macro above | ||
| add_custom_command(TARGET "opencv_perf_${name}" |
Member
There was a problem hiding this comment.
Performance tests are under BUILD_PERF_TESTS guard (line 1125).
Perhaps we need to turn off both BUILD_TESTS / BUILD_PERF_TESTS flags in vcpkg.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review!
I reverted to just if(WINRT) for this instance.
alalek
approved these changes
Aug 3, 2019
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
Fix build for UWP (opencv#15207) * Guard non-WinRT calls to fix UWP build * Remove unnecessary guard for WinRT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #14388
This pullrequest changes
This PR contains some fixes to enable building OpenCV for UWP, these are issues that we came across while trying to package OpenCV for vcpkg (microsoft/vcpkg#5169).
videoiomodule in UWP./APPCONTAINERlinker flag when building tests in order to produce correct DLLs in UWP.