Skip to content

Determine input shapes#15203

Merged
alalek merged 7 commits intoopencv:masterfrom
l-bat:determine_inp_shape
Aug 9, 2019
Merged

Determine input shapes#15203
alalek merged 7 commits intoopencv:masterfrom
l-bat:determine_inp_shape

Conversation

@l-bat
Copy link
Copy Markdown
Contributor

@l-bat l-bat commented Aug 1, 2019 •
edited by alalek
Loading 

force_builders=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2019r2.0:16.04
build_image:Custom Win=openvino-2019r2.0
build_image:Custom Mac=openvino-2019r2.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom Win=windows-1
test_opencl:Custom=OFF

buildworker:Custom=linux-1
test_opencl:Custom=ON
test_bigdata:Custom=1
test_filter:Custom=*

@l-bat l-bat force-pushed the determine_inp_shape branch from 8c2c749 to 7cc3c68 Compare August 2, 2019 11:30
dkurt
dkurt reviewed Aug 2, 2019
View reviewed changes
dkurt
dkurt reviewed Aug 2, 2019
View reviewed changes
dkurt
dkurt reviewed Aug 5, 2019
View reviewed changes
dkurt
dkurt reviewed Aug 5, 2019
View reviewed changes
dkurt
dkurt reviewed Aug 5, 2019
View reviewed changes
dkurt
dkurt reviewed Aug 5, 2019
View reviewed changes
@l-bat l-bat force-pushed the determine_inp_shape branch from 505d5a1 to e3b72ef Compare August 5, 2019 09:46
dkurt
dkurt reviewed Aug 6, 2019
View reviewed changes
dkurt
dkurt reviewed Aug 6, 2019
View reviewed changes
dkurt
dkurt reviewed Aug 7, 2019
View reviewed changes
@dkurt
Copy link
Copy Markdown
Member

dkurt commented Aug 8, 2019 •
edited
Loading

@l-bat, May I ask you to resolve merge conflicts? Thanks!

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Aug 9, 2019

And please include this line back as well in this PR: https://github.com/opencv/opencv/pull/15184/files#diff-060059506235351e720719798d655782L308

@l-bat l-bat force-pushed the determine_inp_shape branch from 04a9cff to d6962ba Compare August 9, 2019 10:42
dkurt
dkurt approved these changes Aug 9, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@dkurt dkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@dkurt dkurt self-assigned this Aug 9, 2019
@alalek alalek merged commit f1ea9d8 into opencv:master Aug 9, 2019
alalek
alalek reviewed Dec 2, 2019
View reviewed changes
modules/dnn/src/dnn.cpp
// set empty input to determine input shapes
for (int inp_id = 0; inp_id < inputsNames.size(); ++inp_id)
{
cvNet.setInput(Mat(inp_shapes[inp_id], CV_32F), inputsNames[inp_id]);
Copy link
Copy Markdown
Member

@alalek alalek Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l-bat @dkurt Looks like this patch is landed for "master" branch only. What is about backporting of this PR?

Copy link
Copy Markdown
Member

@dkurt dkurt Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not mind. Besides cv::dnn::Model other code should be compatible. Let me try to port it.

@dkurt dkurt mentioned this pull request Dec 2, 2019
Merged
This was referenced Feb 18, 2020
Merged
Merged
a-sajjad72 pushed a commit to a-sajjad72/opencv that referenced this pull request Mar 30, 2023
@l-bat
Merge pull request opencv#15203 from l-bat:determine_inp_shape
55fc233 
* Determine input shapes

* Add test

* Remove getInputShapes

* Fix model

* Fix constructors

* Add Caffe test

* Fix predict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek left review comments

@dkurt dkurt dkurt approved these changes

Assignees

@dkurt dkurt

Labels

category: dnn

Projects

None yet

Milestone

4.1.2

Development

Successfully merging this pull request may close these issues.

3 participants

@l-bat @dkurt @alalek