PCH: disable by default on all platforms except MSVC#15195
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Aug 1, 2019
Merged
PCH: disable by default on all platforms except MSVC#15195opencv-pushbot merged 1 commit intoopencv:3.4from
opencv-pushbot merged 1 commit intoopencv:3.4from
Conversation
Contributor
|
just wanted to note that with on gcc/ linux this reduces the compile time by about 40% for clean build for me. However, this does not work with clang and I also noticed PCH related issues when doing incremental builds (working on opencv). |
alalek
approved these changes
Aug 1, 2019
opencv-pushbot
pushed a commit
that referenced
this pull request
Aug 1, 2019
Contributor
Author
|
Yes, clang documentation states that source files must not include PCH header explicitly ( There is some recent related activity in cmake: https://gitlab.kitware.com/cmake/cmake/merge_requests/3553 On *NIX platforms ccache is the best way to speed up repetitive and incremental builds. Our CI can complete clean build in ~1:30-2:00 min in most cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #15157
resolves #14868
This pullrequest changes
Precompiled headers support is very limited and does not give notable compilation speedup on UNIX platforms. Curren PCH generation mechanism does not support targets-based dependencies cmake approach.