Merged
Conversation
adbd2c0 to
50d04be
Compare
06c5bb3 to
b284d30
Compare
alalek
approved these changes
Sep 3, 2019
Member
alalek
left a comment
There was a problem hiding this comment.
Well done! Thank you 👍
I rebased patch onto 3.4 branch.
| #include <opencv2/objdetect.hpp> | ||
| #include <opencv2/highgui.hpp> | ||
| #include <opencv2/imgproc.hpp> | ||
| #include <opencv2/videoio.hpp> |
Member
There was a problem hiding this comment.
Probably we should keep separate include of "videoio" module - VideoCapture is used below.
(due compatibility "videoio" headers are included by "highgui" header, but this doesn't look consistent - lets show to Users which modules are used)
Contributor
Author
There was a problem hiding this comment.
@alalek OK. let me add #include <opencv2/videoio.hpp> in all samples uses VideoCapture
please don't merge until i inform you.
04167e7 to
311125f
Compare
Member
|
@sturkmen72 Could you please take a look on build failures? |
550092a to
f733951
Compare
Contributor
Author
|
@alalek i think the PR is ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest changes
updates samples